Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: on insert of duplicate task, handle error more gracefully (0.x) #3338

Merged
merged 1 commit into from
Mar 19, 2023
Merged

core: on insert of duplicate task, handle error more gracefully (0.x) #3338

merged 1 commit into from
Mar 19, 2023

Conversation

mworrell
Copy link
Member

Description

On a race condition a duplicate task could be inserted.
This makes the error less vocal and returns the id of the task that already exists.

Checklist

  • documentation updated
  • tests added
  • no BC breaks

@mworrell mworrell added this to the 0.76.0 milestone Mar 19, 2023
@mworrell mworrell requested a review from mmzeeman March 19, 2023 07:44
mmzeeman
mmzeeman approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@mmzeeman mmzeeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah... select for update. I could try that on the identity table too.

@mmzeeman mmzeeman merged commit 16dfdb2 into 0.x Mar 19, 2023
@mmzeeman mmzeeman deleted the insert-task-duplicate-0x branch March 19, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmzeeman mmzeeman mmzeeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.76.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mworrell @mmzeeman