-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support MSW 2 #36
Support MSW 2 #36
Conversation
wow, thanks for you work! I'll look into it asap |
Thanks for this tool! This has been tested on a real Node.js project, also added a React Native test but I don't use it personally. Examples using
|
works great here too, thanks! one note, it's best to not go backwards in version numbers, it'll cause issues with some tools |
FIXME: without --node > No known conditions for "./browser" specifier in "msw" package
Thanks @Briaoeuidhtns, good point, deleted the version change commit. Also rebased changes using |
The test is failing in CI because |
Hi, any plans to release this as npm package for msw 2.0? |
Here is an attempt to migrate the template to work with MSW 2.0 according to https://mswjs.io/docs/migrations/1.x-to-2.x/ that may close #35, or at least help in the meantime.
Also added a regression test verifying the examples are valid (first commit works on 0.15.0).
Since this is a breaking change, I guess the version should be updated too. It might require more testing.