Add querying helpers #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjmconie
reviewed
Jul 1, 2018
| return nil | ||
| } | ||
|
|
||
| /// Return `true` iff this is `.null` |
There was a problem hiding this comment.
cjmconie
reviewed
Jul 1, 2018
GenericJSON/Querying.swift
Outdated
| /// | ||
| /// If this is not an `.array` or the index is out of bounds, returns `nil`. | ||
| public subscript(index: Int) -> JSON? { | ||
| if case .array(let arr) = self, index < arr.count { |
There was a problem hiding this comment.
We check the upper bound of the array here, does it make sense to check the lower bound (i.e. index >= 0) too? Currently, an overflow in one direction returns nil and the other direction will trigger a fatal index out of range exception.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are helpers to query values stored in a
JSONvalue proposed by @cjmconie in #2. Cameron, is this OK? I have mostly just copied your code and added some tests.