Added RTree3D wrapper #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavincangan
commented
Apr 17, 2019
gavincangan
commented
- Added a RTree3D class similar to the existing RTree
- Added simple tests for RTree3D functions in a jupyter notebook in ./tests (I have more tests in my other project that I am using them in)
Former-commit-id: 07c4a789dceee0cd71affc5371abf867f6c78b34
Former-commit-id: 8cb3dd68bffbfe77e6fb97f2e5747504612e0567
Former-commit-id: 0707a4783156b50cb574caee1ad22e1702d7df18
|
Please remove all |
|
zouzias
reviewed
Apr 19, 2019
setup.py
Outdated
| @@ -39,6 +39,7 @@ | |||
| print('| Ubuntu: apt-get install libboost-all-dev |') | |||
| print('| Manually: wget https://sourceforge.net/projects/boost/files/boost/1.65.1/boost_1_65_1.tar.gz|') | |||
| print('=' * 40) | |||
| os.environ['BOOST_ROOT'] = '/usr/include' | |||
setup.py
Outdated
| @@ -62,7 +63,7 @@ | |||
| sources=sources, | |||
| language="c++", | |||
| extra_compile_args=compile_args, | |||
| include_dirs=[numpy.get_include(), os.environ['BOOST_ROOT'], 'include'] | |||
| include_dirs=[numpy.get_include(), os.environ['BOOST_ROOT'], 'include', '/usr/include', '/usr/include/x86_64-linux-gnu'] | |||
There was a problem hiding this comment.
You can set BOOST_ROOT=/usr/include/x86_64-linux-gnu here, no?
src/RTreePoint3D.cpp
Outdated
|
|
||
| void RTreePoint3D::insertPoints(double* points, long m, long n) | ||
| { | ||
| assert(n == 4); // points should be an m x 3 matrix |
There was a problem hiding this comment.
Update comment, it is m x 4 now.
…th manually, which obviously does not work well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.