Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow independent version updates with lerna #114

Merged
merged 8 commits into from
Oct 6, 2023

Conversation

t1m0thyj
Copy link
Contributor

@t1m0thyj t1m0thyj commented Oct 2, 2023

Here is an example of a pull request that adds a package with an independent version like Imperative:
t1m0thyj/zowe-deploy-test#117

Release workflow succeeded: https://github.com/t1m0thyj/zowe-deploy-test/actions/runs/6410315542/job/17403386054

Version bump commit was created: t1m0thyj/zowe-deploy-test@a3a0b3b

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Copy link
Collaborator

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! 🥳

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj force-pushed the feat/lerna-independent-version branch from 7b4cfa2 to c086d37 Compare October 3, 2023 21:33
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj requested a review from a team October 4, 2023 19:04
@t1m0thyj t1m0thyj marked this pull request as ready for review October 4, 2023 19:04
Copy link
Collaborator

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Copy link

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @t1m0thyj!

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj merged commit 6d49a3e into master Oct 6, 2023
4 checks passed
@t1m0thyj t1m0thyj deleted the feat/lerna-independent-version branch October 6, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants