Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the @core/actions library #93

Merged
merged 2 commits into from
May 22, 2023

Conversation

MarkAckert
Copy link
Contributor

The core/actions library should be upgraded to 1.10.0 or later to avoid complications from set-output and save-state deprecation.

See: https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md

Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
Copy link
Contributor

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MarkAckert!

Should we update the v1 tag after merging this?

Signed-off-by: MarkAckert <mark.ackert@broadcom.com>
@MarkAckert
Copy link
Contributor Author

Hey, I think we should update the tag...there's no breaking changes here. It's more likely users of v1 will break on May 31 if we don't update the tag.

@t1m0thyj
Copy link
Contributor

Going to update the v1 tag after this and #94 have been merged

@t1m0thyj t1m0thyj merged commit 9cb8a64 into master May 22, 2023
6 checks passed
@t1m0thyj t1m0thyj deleted the user/markackert/update-actions-core branch May 22, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants