Fix for bug 264: API Gateway is bypassed when server return 302

[CindyZX]

No description provided.

[JirkaAichler]

Hello Cindy,
thank you for your contribution into APIML. We really appropriate that!

I will review it as soon as possible. Do you think you could meantime create also integration test for it?

[codecov]

Codecov Report

Merging #276 into master will decrease coverage by 0.78%.
The diff coverage is 84.33%.

@@             Coverage Diff              @@
##             master     #276      +/-   ##
============================================
- Coverage      70.2%   69.42%   -0.79%     
  Complexity       12       12              
============================================
  Files           231      235       +4     
  Lines          4612     4500     -112     
  Branches        588      568      -20     
============================================
- Hits           3238     3124     -114     
  Misses         1223     1223              
- Partials        151      153       +2

Impacted Files	Coverage Δ	Complexity Δ
...m/ca/mfaas/gateway/routing/MfaasRoutingConfig.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...ca/mfaas/client/api/PageRedirectionController.java	100% <100%> (ø)	0 <0> (?)
...a/com/ca/mfaas/product/routing/RoutedServices.java	96.87% <100%> (+0.1%)	0 <0> (ø)	⬇️
...ava/com/ca/mfaas/gateway/config/GatewayConfig.java	100% <100%> (ø)	0 <0> (?)
...va/com/ca/mfaas/client/model/RedirectLocation.java	100% <100%> (ø)	0 <0> (?)
...as/product/routing/transform/TransformService.java	100% <100%> (ø)	0 <0> (ø)	⬇️
...main/java/com/ca/mfaas/product/utils/UrlUtils.java	76.92% <50%> (-11.97%)	0 <0> (ø)
...as/gateway/filters/post/PageRedirectionFilter.java	87.93% <87.93%> (ø)	0 <0> (?)
.../main/java/com/ca/mfaas/security/HttpsFactory.java	72.22% <0%> (-8.83%)	0% <0%> (ø)
...og/services/cached/CachedProductFamilyService.java	86.52% <0%> (-1.66%)	0% <0%> (ø)
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4bf185...85c4f5f. Read the comment docs.

[CindyZX]

Hi @JirkaAichler , sure, I will add some integration test

[CindyZX]

I just modified the PR to add integration test. I added a new controller: PageRedirectionController to discoverable-client for the integration test. It accepts POST request, gets a url from the POST data, then set the url to response's Location header, and return status code 307

[ilkinabdullayev]

Hi Cindy,
Thanks for supporting to the api-layer!
We implemented new simple service(com.ca.mfaas.product.routing.transform.TransformService) which is transforming service urls into gateway urls. You will see this service(TransformService) once you pull the master branch.
I think you could use this service instead of your own code.

[taban03]

Hello @CindyZX , as @ilkinabdullayev said we have applied some changes which can be helpful for you and which is now in master. One of those changes is also involving the getBestMatchingServiceUrl that you're using in foundMatchedUrlInService, since we have improved it.

[arxioly]

Thank you, @CindyZX, for applying my suggestions. This is last one.

[JirkaAichler]

Great work Cindy!

Just one last idea. Please put the max size constant into the original class (filter). ApimlConstants should be used for constants which are reusable by other classes.

I would also increase it to 1000. But honestly, I don't know what is the ideal size :-)

Thanks!

[CindyZX]

@JirkaAichler Thanks Jirka, I've put max entry constant back to the filter class and set it to 1000

[JirkaAichler]

Awesome work. Thank you Cindy!

[ilkinabdullayev]

Thanks, Cindy!