Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AT-TLS handler for WebFlux #3544

Merged
merged 4 commits into from
May 16, 2024

Conversation

pj892031
Copy link
Contributor

Description

This PR wrap filter is responsible for communication between Apache Tomcat and Spring WebFlux implementation. It handles whether AT-TLS is enabled or not and updates the client certificate in the request.

The handler could cancel the request (by sending an error message to the customer) or set values to propagate. The request attribute will contain attls property with the context. It prevents reading the context inside WebFlux (a different thread could handle each part of the treatment, but the attributes are still the same).

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@achmelo achmelo merged commit 6ced020 into reboot/cgw-tomcat-poc May 16, 2024
1 of 2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reboot/scgw-attls-handling branch May 16, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants