Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Disable integration test that hangs on Windows #456

Merged
merged 1 commit into from Nov 2, 2020
Merged

Conversation

t1m0thyj
Copy link
Member

Temporarily disable node-pty test on Windows until microsoft/node-pty#437 is fixed.

Also update Keytar dependency in Imperative test CLI to support Node 14.

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Copy link
Member

@awharn awharn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We will just need to remember to revert the logic on this test when that issue is resolved.

Copy link
Member

@gejohnston gejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_212) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11.
Read more here
warning The version of Node.js (v8.16.0) you have used to run this analysis is deprecated and we will stop accepting it from 16th November 2020. Please update to at least Node.js 10. Read more here

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #456 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
+ Coverage   82.09%   82.14%   +0.05%     
==========================================
  Files         162      162              
  Lines        7750     7750              
  Branches     1384     1384              
==========================================
+ Hits         6362     6366       +4     
+ Misses       1384     1380       -4     
  Partials        4        4              
Impacted Files Coverage Δ
packages/cmd/src/response/CommandResponse.ts 97.02% <0.00%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4543e9b...4ee04b9. Read the comment docs.

@t1m0thyj t1m0thyj merged commit 10f3d8d into master Nov 2, 2020
@mheuzey mheuzey mentioned this pull request Nov 11, 2020
@t1m0thyj t1m0thyj deleted the disable-node-pty branch November 12, 2020 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants