Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Fix failure to load schema when there is no profile of that type #916

Merged
merged 6 commits into from Dec 14, 2022
Merged

Fix failure to load schema when there is no profile of that type #916

merged 6 commits into from Dec 14, 2022

Conversation

t1m0thyj
Copy link
Member

Fixes #645

@t1m0thyj
Fix failure to load schema when there is no profile of that type
1dc7dcb 
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj
Handle cases when getDefaultProfile returns null
e5e73f3 
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj
Update changelog
cbff8b0 
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@codecov
Copy link

codecov bot commented Dec 12, 2022 •
edited

Codecov Report

Base: 89.33% // Head: 89.34% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (63635ea) compared to base (a82c30f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #916   +/-   ##
=======================================
  Coverage   89.33%   89.34%           
=======================================
  Files         206      206           
  Lines       11180    11187    +7     
  Branches     2488     2488           
=======================================
+ Hits         9988     9995    +7     
  Misses       1192     1192
Impacted Files Coverage Δ
packages/config/src/ProfileInfo.ts 97.52% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

zFernand0
zFernand0 reviewed Dec 12, 2022
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM!
However, I'm waiting for clarification on some of my comments/questions before I approve it

packages/config/__tests__/ProfileInfo.TeamConfig.test.ts Show resolved Hide resolved
packages/config/src/ProfileInfo.ts Outdated Show resolved Hide resolved
@t1m0thyj
Cache old school profile types and add missing ensureReadFromDisk calls
f1e3e9f 
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
zFernand0
zFernand0 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Left a small question. The question only applied to ZE

packages/config/src/ProfileInfo.ts Show resolved Hide resolved
packages/config/__tests__/ProfileInfo.TeamConfig.test.ts Show resolved Hide resolved
@t1m0thyj
Merge branch 'master' into fix/profinfo-schema-error
1cc616e 
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj
Fix failing unit test for old profiles
63635ea 
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@t1m0thyj t1m0thyj merged commit f94bca1 into master Dec 14, 2022
@t1m0thyj t1m0thyj deleted the fix/profinfo-schema-error branch December 14, 2022 16:03
@t1m0thyj t1m0thyj added the release-patch Indicates a patch to existing code has been applied label Dec 14, 2022
@github-actions
Copy link

Release succeeded for the master branch. 🎉

The following packages have been published:

  • npm: @zowe/imperative@5.7.5

Powered by Octorelease 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zFernand0 zFernand0 zFernand0 approved these changes

@gejohnston gejohnston gejohnston approved these changes

@traeok traeok traeok approved these changes

@awharn awharn Awaiting requested review from awharn

@KevinLoesch1 KevinLoesch1 Awaiting requested review from KevinLoesch1

@ATorrise ATorrise Awaiting requested review from ATorrise

Assignees
No one assigned
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to load schema for profile type sample
4 participants
@t1m0thyj @gejohnston @zFernand0 @traeok