Fix plugin install error not displayed correctly

[t1m0thyj]

Fixes #954 by adding utility method ProcessUtils.execAndCheckOutput that wraps child_process.spawnSync for better error handling.

Notes:

• Renamed methods in NpmFunctions.ts and removed an unused one - not a breaking change since this module is not exported
• The reason for using http://localhost:4873/ as npm registry in some tests is that's the default port used by Verdaccio 🙂

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11 🎉

Comparison is base (df36dce) 89.39% compared to head (cd0bc88) 89.51%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
+ Coverage   89.39%   89.51%   +0.11%     
==========================================
  Files         207      207              
  Lines       11264    11259       -5     
  Branches     2506     2507       +1     
==========================================
+ Hits        10070    10078       +8     
+ Misses       1194     1181      -13     

Impacted Files	Coverage Δ
...s/imperative/src/config/cmd/report-env/EnvQuery.ts	96.09% <100.00%> (ø)
...s/imperative/src/plugins/utilities/NpmFunctions.ts	100.00% <100.00%> (+37.50%)	⬆️
...e/src/plugins/utilities/npm-interface/uninstall.ts	94.11% <100.00%> (-0.17%)	⬇️
...erative/src/plugins/utilities/runValidatePlugin.ts	100.00% <100.00%> (ø)
packages/utilities/src/ProcessUtils.ts	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[zFernand0]

Changes LGTM!

Will approve once we determine if removing getNpmPath is ok 😋

[zFernand0]

Should we throw an ImperativeError?

There may be other places where we throw non Imperative errors. For example:

• throw new Error("Failed to uninstall plugin, install folder still exists:\n " + installFolder);

[t1m0thyj]

This method is intended to be low-level and mimic the error handling behavior of child_process.execSync. If we throw an Imperative error that wraps the original error, it may affect how the original error gets logged. I'm open to switching if we think that using vanilla JS errors is bad practice here 🙂

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[github-actions]

Release succeeded for the master branch. 🎉

The following packages have been published:

• npm: @zowe/imperative@5.9.2

_{Powered by Octorelease 🚀}