-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating existing documentation for the sample #36
Conversation
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
============================================
+ Coverage 78.19% 78.67% +0.48%
- Complexity 46 47 +1
============================================
Files 21 22 +1
Lines 133 136 +3
Branches 3 3
============================================
+ Hits 104 107 +3
Misses 27 27
Partials 2 2
Continue to review full report at Codecov.
|
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Fixed problems discovered by Dan:
|
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me and Petr reviewed this PR.
Resolves #8, resolves #22, and resolves #33
The documentation that is listed in #8 has been reviewed and migrated to the sample where it was possible.
Please review the new documentation if it makes sense and is helpful to you.
The message format class from the
common-service-code
were migrated as well under new package name with prefixorg.zowe.commons.error
. This code has been already review when developed by @JirkaAichler and Vasyl so you do not need to spend much time on this but your comments will be appreciated.