Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating existing documentation for the sample #36

Merged
merged 21 commits into from
Sep 13, 2019
Merged

Migrating existing documentation for the sample #36

merged 21 commits into from
Sep 13, 2019

Conversation

plavjanik
Copy link
Contributor

@plavjanik plavjanik commented Sep 5, 2019

Resolves #8, resolves #22, and resolves #33

The documentation that is listed in #8 has been reviewed and migrated to the sample where it was possible.

Please review the new documentation if it makes sense and is helpful to you.

The message format class from the common-service-code were migrated as well under new package name with prefix org.zowe.commons.error. This code has been already review when developed by @JirkaAichler and Vasyl so you do not need to spend much time on this but your comments will be appreciated.

Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
@codecov-io
Copy link

codecov-io commented Sep 5, 2019

Codecov Report

Merging #36 into master will increase coverage by 0.48%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #36      +/-   ##
============================================
+ Coverage     78.19%   78.67%   +0.48%     
- Complexity       46       47       +1     
============================================
  Files            21       22       +1     
  Lines           133      136       +3     
  Branches          3        3              
============================================
+ Hits            104      107       +3     
  Misses           27       27              
  Partials          2        2
Impacted Files Coverage Δ Complexity Δ
...we/sample/apiservice/config/ApplicationConfig.java 100% <ø> (ø) 3 <0> (ø) ⬇️
.../org/zowe/sample/apiservice/wto/WtoController.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...e/greeting/GreetingControllerExceptionHandler.java 100% <100%> (ø) 2 <2> (?)
...owe/sample/apiservice/greeting/EmptyNameError.java 100% <100%> (ø) 1 <1> (?)
...sample/apiservice/greeting/GreetingController.java 100% <100%> (ø) 4 <2> (?)
...we/sample/apiservice/config/WebSecurityConfig.java 100% <100%> (ø) 3 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed85421...0e9836b. Read the comment docs.

Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
@plavjanik plavjanik changed the title wip - Migrating existing documentation for the sample Migrating existing documentation for the sample Sep 6, 2019
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
@plavjanik
Copy link
Contributor Author

Fixed problems discovered by Dan:

  • Missing WWW-Authenticate header on 401 when no authentication has been provided
  • No error where .so was not build prior packaging JAR

Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Copy link
Contributor

@VitekVlcek-Broadcom VitekVlcek-Broadcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me and Petr reviewed this PR.

@plavjanik plavjanik merged commit 4db8fd9 into master Sep 13, 2019
@plavjanik plavjanik deleted the docs branch October 5, 2019 05:30
@plavjanik plavjanik added this to Done in SDK MVP Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
SDK MVP
  
Done
3 participants