-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n for REST APIs and error messages #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
plavjanik
commented
Oct 31, 2019
zowe-rest-api-commons-spring/src/test/java/org/zowe/commons/error/ErrorServiceImplTest.java
Outdated
Show resolved
Hide resolved
plavjanik
commented
Oct 31, 2019
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
What needs to be done for Czech accented characters on the mainframe:
|
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
dkelosky
approved these changes
Nov 5, 2019
This was referenced Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a first pull request for #39.
The documentation and instructions are in https://github.com/zowe/sample-spring-boot-api-service/pull/68/files?short_path=d9af631#diff-d9af6310659c7ac8fee1baf3ab693bd1.
The Swagger/Springfox localization is not in this PR and it will be delivered in another PR. This one is over 700 lines now which a high number already.
The Czech localization is not complete and it is not the goal - the purpose is only for testing, not to provide a complete localization.
I realized that some things in the original error messages functionality from the old SDK could be done nicer (e.g. use ResourceBundles, or same formatting using curly braces
{}
as the Spring instead of C-style) but I tried to preserve the existing API and messages.yml format and just add new functionality on top of it so existing users are not affected.ErrorService
)Suggestions:
.properties
files) with unlocalized and commented text that can be easily translated without going back and forth to the original one and verifies that the translation is complete - added as zowe-api-dev command for i18n and messages #70