Check for empty password before calling PlatformUser #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks for an empty password before calling
PlatformUser.authenticate()
method from IBM JDK that could succeed in this situation. This has been a valid behavior of the underlying BPX4PWD callable service:So it could succeed with an empty password in cases when the server user ID passed the
SURROGAT
class check.Since it is a highly unexpected behavior that is documented three levels below the
org.zowe.commons.zos.security.platform.PlatformUser.authenticate()
documentation, theorg.zowe.commons.zos.security.platformPlatformUser.authenticate()
will fail with errnoEINVAL
(121). If theSURROGAT
class check is needed in future then it will be implemented a special method to prevent this confusion.Resolves #72