Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1601

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Update dependencies #1601

merged 3 commits into from
Dec 2, 2021

Conversation

lauren-li
Copy link
Contributor

@lauren-li lauren-li commented Dec 2, 2021

Proposed changes

This PR includes the following updates:

  • Update dependencies based on Dependabot recommendations.
  • Remove extra package-lock.json files.
  • Update to i18n sample file that was missed from a previous PR

The dependencies resolved in this PR are transitive, and based on our dependencies that use them (*see next section), the following items make sense to target in regression testing:

  • Prepublish and package commands
  • Integration tests (Test that they run normally)

Direct dependencies affected by this PR

*In the future, we may be able to remove items added to resolutions in this PR by updating the following dependencies:

  • vsce
  • mocha
  • eslint, @typescript-eslint-parser, @typescript-eslint-plugin

Release Notes

Milestone: 1.21.0

Changelog: Update dependencies for improved security.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Reminder

After a PR is merged into the master branch, create a PR from master to the next branch resolving any conflicts.

Signed-off-by: Lauren Li <45975633+lauren-li@users.noreply.github.com>
@crawr crawr added this to the 1.21.0 milestone Dec 2, 2021
Copy link
Contributor

@jellypuno jellypuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @lauren-li

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @lauren-li

@JillieBeanSim JillieBeanSim merged commit f634452 into master Dec 2, 2021
@JillieBeanSim JillieBeanSim deleted the update-dependencies branch December 2, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants