-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSO fix for using config file #1801
Conversation
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
…sion-for-zowe into tso-acct-issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I tested this PR by following the recreation steps from the user, the tests are passing as well!
Thanks for this fix @JillieBeanSim !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM and make sense.
I added a comment about the usage of getProfileInfo
(from globals
)
let mProfileInfo = await globals.PROFILESCACHE.getProfileInfo(); | ||
if (!mProfileInfo) { | ||
mProfileInfo = await Profiles.getInstance().getProfileInfo(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious if there is a better way to implement this.
Maybe modifying the getProfileInfo
to return the instance stored in the class if defined
If not, then create a new one ?
(This may have other implications though)
I guess I can see myself forgetting that the globals
instance can be undefined
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Fernando, I know we spoke of possibly creating an instance in the future of getProfileInfo() to improve performance. I wonder if we need to create a new story to handle that since here with the globals it is actually an instance of ProfilesCache that is created during activation. Not sure why the call is failing in this case but not others though.
Proposed changes
addresses issue #1786
User shouldn't be prompted for account number if it is already included in the config file under the TSO profile.
Release Notes
Milestone:
Changelog: Bugfix: Fix issue with user being prompted for account number while issuing TSO command when config file already includes the account number for TSO profile.
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...