add workflow to test build #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 7, 2023 16:55
Signed-off-by: James Struga <jstruga@rocketsoftware.com>
Signed-off-by: James Struga <jstruga@rocketsoftware.com>
Signed-off-by: James Struga <jstruga@rocketsoftware.com>
Signed-off-by: James Struga <jstruga@rocketsoftware.com>
.github/workflows/build_test.yml
Outdated
| @@ -0,0 +1,52 @@ | |||
| name: Build and Test Workflow | |||
| name: Build and Test Workflow | ||
| on: | ||
| push: | ||
| branches: |
There was a problem hiding this comment.
how about on manual trigger too, or not?
There was a problem hiding this comment.
Glad this is working for you but note these comments, and then consider this: https://github.com/TSTerminal/TSTerm/tree/main/.github/workflows
Why not make a 2 workflow approach as seen here: 1) on every PR, build the assets and upload to the github workflow
2) on merge to main, do a "draft release"
it means you automatically get nice content like this https://github.com/TSTerminal/TSTerm/releases
Signed-off-by: James Struga <jstruga@rocketsoftware.com>
added 6 commits
August 8, 2023 14:20
Signed-off-by: James Struga <jstruga@rocketsoftware.com>
Signed-off-by: James Struga <jstruga@rocketsoftware.com>
Signed-off-by: James Struga <jstruga@rocketsoftware.com>
Signed-off-by: James Struga <jstruga@rocketsoftware.com>
1000TurquoisePogs
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.