Password Reset #193
Password Reset #193
Conversation
Signed-off-by: Suneeth Keerthy <skeerthy@rocketsoftware.com>
| "width": 400, | ||
| "height": 400, | ||
| "x": 0, | ||
| "y": 0 |
| "pluginType": "application", | ||
| "isSystemPlugin":true, | ||
| "webContent": { | ||
| "framework": "angular2", |
There was a problem hiding this comment.
@1000TurquoisePogs Plenty of apps still have "angular2" btw, not sure if that is a big deal
| {username: this.username, password: password, newPassword: newPassword}) | ||
| .subscribe( | ||
| result => { | ||
| this.response = result.json().categories.zss.plugins['org.zowe.zlux.auth.zss'].response |
There was a problem hiding this comment.
do not hardcode plugin names. you need to store which plugins can password reset. utilize the app manager's authentication manager.
| @@ -0,0 +1,27 @@ | |||
|
|
|||
There was a problem hiding this comment.
You can delete the environments folders. Its actually not used by angular components, only angular websites. apps are just components.
| @@ -0,0 +1,33 @@ | |||
|
|
|||
There was a problem hiding this comment.
You can also delete index.html, components dont use it.
| }, | ||
| ] | ||
| }, | ||
| 'plugins': [ |
There was a problem hiding this comment.
you should add in the compress webpack plugin we use in the terminals & virtual-desktop plugins. it makes loading faster because the content is 1/3 the size when compressed.
virtual-desktop/src/app/authentication-manager/authentication-manager.service.ts
Show resolved
Hide resolved
| result => { | ||
| let jsonMessage = result.json(); | ||
| this.expiredPassword = false; | ||
| this.loginMessage = jsonMessage.categories.zss.plugins['org.zowe.zlux.auth.zss'].response; |
There was a problem hiding this comment.
do not hardcode this. store knowledge of which plugin is being asked for ahead of time, and look for the one you asked for, or since you only ask to reset 1 password just change the response body to just have the contents of that one plugin, without having the name of it.
| @@ -216,14 +251,18 @@ export class LoginComponent implements OnInit { | |||
| failedTypes.push(keys[i]); | |||
| } | |||
| } | |||
| this.errorMessage = this.translation.translate('AuthenticationFailed', | |||
| if (error.status == 428) { | |||
There was a problem hiding this comment.
428 is not a common number (to me) so it should be a constant for readability.
| @@ -69,7 +71,7 @@ export class LaunchbarComponent { | |||
| if (p.identifier === 'org.zowe.zlux.appmanager.app.propview') { | |||
| const pluginImpl:DesktopPluginDefinitionImpl = p as DesktopPluginDefinitionImpl; | |||
| this.propertyWindowPluginDef = pluginImpl; | |||
| } else if (p.identifier === 'org.zowe.zlux.ng2desktop.settings') { | |||
| } else if (SYSTEM_APPS.indexOf(p.identifier) != -1) { | |||
There was a problem hiding this comment.
just fyi this will code conflict with my stuff because i change this too
Signed-off-by: Suneeth Keerthy <skeerthy@rocketsoftware.com>
Signed-off-by: Suneeth Keerthy <skeerthy@rocketsoftware.com>
…on expire page from overlapping Signed-off-by: Suneeth Keerthy <skeerthy@rocketsoftware.com>
Signed-off-by: Suneeth Keerthy <skeerthy@rocketsoftware.com>
Signed-off-by: Suneeth Keerthy <skeerthy@rocketsoftware.com>
Signed-off-by: Suneeth Keerthy <skeerthy@rocketsoftware.com>
| if (this.newPassword != this.confirmNewPassword) { | ||
| this.errorMessage = "New passwords do not match. Please try again."; | ||
| } else { | ||
| this.authenticationService.performPasswordReset(this.username, this.password, this.newPassword, ZSS_AUTH).subscribe( |
There was a problem hiding this comment.
You need to find out the plugin that can do the PW reset by reading the response to login. If you see "canChangePw" on any, record which one, and then use it here. If you find 0, you need to hide the pw panels, and if password=expired, then you just need to fail, rather than provide the reset option if it doesnt exist.
| return this.authenticationManager.getUsername() != null ? true : false; | ||
| } | ||
|
|
||
| hideVisibleApplications(): void { |
There was a problem hiding this comment.
JUst change login screen to set the wallpaper and stop being transparent, since it avoids messing around with the windows.
| @@ -57,6 +60,10 @@ export class PersonalizationComponent { | |||
| "title":this.translation.translate("Languages"), | |||
| "imgSrc":"foreign_language", | |||
| }, | |||
| { | |||
| "title":CHANGE_PASSWORD, | |||
| "imgSrc":"password" | |||
There was a problem hiding this comment.
this.translation.translate("Password")
In the ja japanese translation JSON file, you can set "password": " パスワード "
Signed-off-by: Suneeth Keerthy <skeerthy@rocketsoftware.com>
Signed-off-by: Suneeth Keerthy <skeerthy@rocketsoftware.com>
Signed-off-by: Suneeth Keerthy <skeerthy@rocketsoftware.com>
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Center login screen along y axis
…logged in not letting you change the password Signed-off-by: Suneeth Keerthy <skeerthy@rocketsoftware.com>
…VDHosting from auth manaager Signed-off-by: Suneeth Keerthy <skeerthy@rocketsoftware.com>
WIP
Goes along with:
zowe/zss#161
zowe/zowe-common-c#128
zowe/zlux-app-server#106
zowe/zss-auth#29
zowe/zlux-server-framework#181
zowe/zlux-platform#52
Signed-off-by: Suneeth Keerthy skeerthy@rocketsoftware.com