New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Browser App #194

Merged

lchudinov merged 65 commits into zowe:staging from lchudinov:feature/create-web-browser-app

Apr 16, 2020

Contributor

lchudinov commented Mar 13, 2020 •

edited

Zowe Web Browser Application

Demo

##App2App Demo

Launch Metadata

export interface WebBrowserLaunchMetadata {
  url: string;
  hideControls: boolean;
  enableProxy: boolean;
}

Environment variables

ZOWE_WEB_BROWSER_PROXY_PORT_RANGE=8551..8580

lchudinov force-pushed the feature/create-web-browser-app branch 10 times, most recently from 0ea8edc to 6a93df7 Compare

March 23, 2020 11:38

lchudinov force-pushed the feature/create-web-browser-app branch 4 times, most recently from aa09dc9 to b10d8c2 Compare

March 26, 2020 10:52

lchudinov requested review from 1000TurquoisePogs and a team

March 26, 2020 10:55

lchudinov changed the title ~~[WIP] Web Browser App~~ Web Browser App

DivergentEuropeans reviewed

View reviewed changes

Member

DivergentEuropeans left a comment •

edited

Just a few things I noticed, looked through like a third of the code. Overall, very impressive, lots of hours have been put in, I see and a nice job! Also great GIFs, I love when developers use GIFs/screenshots to show visual things 🍨

system-apps/web-browser-app/doc/swagger/proxy.yaml Show resolved Hide resolved

system-apps/web-browser-app/webClient/src/app/app.component.ts Show resolved Hide resolved

system-apps/web-browser-app/webClient/src/app/browser/address-bar/address-bar.component.ts Show resolved Hide resolved

system-apps/web-browser-app/webClient/src/app/browser/address-bar/address-bar.component.ts Outdated Show resolved Hide resolved

system-apps/web-browser-app/webClient/src/app/browser/bookmark-bar/bookmark-bar.component.ts Show resolved Hide resolved

...-apps/web-browser-app/webClient/src/app/browser/browser-window/browser-window.component.html Show resolved Hide resolved

...em-apps/web-browser-app/webClient/src/app/browser/browser-window/browser-window.component.ts Show resolved Hide resolved

...-apps/web-browser-app/webClient/src/app/browser/browser-window/browser-window.component.scss Outdated Show resolved Hide resolved

system-apps/web-browser-app/webClient/src/app/browser/address-bar/address-bar.component.scss Show resolved Hide resolved

system-apps/web-browser-app/webClient/src/app/browser/services/bookmarks.service.ts Outdated Show resolved Hide resolved

lchudinov force-pushed the feature/create-web-browser-app branch from d944d71 to 0e5b5ff Compare

April 9, 2020 04:20

Leonty Chudinov added 11 commits

April 16, 2020 11:44


          Web Browser App: Initial Commit

a7a42fb

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Add copyright text

1a24731

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Remove dependency on zlux-widgets

84462b8

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Begin with Proxy service

5b999ee

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: More work on Proxy Service

d0dd2b9

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Properly handle redirects

cc38339

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Improvements for browser window

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: First attempt to handle cookies and redirects correctly

d29fa02

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Allow to follow redirects

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Include Carbon components

da661b1

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Switch to use sccs

c4086ce

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>

Leonty Chudinov added 22 commits

April 16, 2020 11:44


          Web Browser App: Make bookmarks work

184298c

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Automatically turn on proxy if protocol is http

e707944

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Minor refactoring

c145e93

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Ability to remove bookmarks

5f7ec4c

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Style fix

3b524e5

Add bottom border for address-bar

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Preserve URL path and query when constructing URL fo…

8b504d7

…r IFrame

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Refactoring

a991e4c

Rename Bookmarks component to BookmarkBar component

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: i18n for html templates

2fcd552

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Refactoring for Proxy Server

7dbdece

* Simplify proxy reuse

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Proxy server refactoring

aa51928

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Fix swagger doc for proxy service

1aebf25

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Amend Readme.md

f547488

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Improve bookmark bar appearance

3668fd7

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Fix for Proxy checkbox

33f7822

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Cleanup package.json

295e357

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Add metadata into proxy response

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Fix for key/cert pairs

8f04ab7

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Minor fix

ec48a43

Use require for bluebird

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Add Copyright and link to external docs into proxy.yaml

b52b3ed

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Address code review issues

77919a0

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Add Russian translation for pluginDefinition.json

7ee2f47

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Fix default port range for proxy

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>

lchudinov force-pushed the feature/create-web-browser-app branch from cab8ab8 to 0852507 Compare

April 16, 2020 06:45

Leonty Chudinov added 3 commits

April 16, 2020 17:17


          Web Browser App: Minor fix

73d44f3

Remove mistakenly added id

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Add prefixes to CSS classes

703c12e

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>


          Web Browser App: Add icon

feec016

Signed-off-by: Leonty Chudinov <lchudinov@rocketsoftware.com>

Member

1000TurquoisePogs commented Apr 16, 2020

Looks like all issues addressed, tested as working, last thing is that I will add japanese translations in another pr soon.

1000TurquoisePogs approved these changes

View reviewed changes

lchudinov merged commit f985fbd into zowe:staging

lchudinov deleted the feature/create-web-browser-app branch

April 16, 2020 15:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment