opening a new file scrolls file bar to the newly opened file #69
Conversation
Signed-off-by: aarora4 <lazyc78@gmail.com>
| ngAfterViewChecked() { | ||
| const changes = this.iterableDiffer.diff(this.data); | ||
| if (changes) { | ||
| this.componentRef.directiveRef.scrollToRight(); |
There was a problem hiding this comment.
This is half right: you scroll to right when opening.
But if I close, although it selects the one all the way to the left (which is fine), it doesn't scroll to the left.
I suggest listening on editorControl for a close event and doing scrollToLeft() if possible.
Signed-off-by: aarora4 <lazyc78@gmail.com>
Signed-off-by: aarora4 <lazyc78@gmail.com>
| return; | ||
| } | ||
|
|
||
| this.componentRef.directiveRef.scrollToElement(`.tabs-file-list > li:nth-child(${i + 1})`); |
There was a problem hiding this comment.
I have a new problem with this branch: I can't scroll my list (though my list can be auto-scrolled by closing & opening), and am having trouble clicking to change tabs for some tabs near the left or right sides.
I think it's this line of code, but not certain. Basically, you only would want to auto-scroll if there has been a change in the quantity, but here it's just after view check, which I believe could be for a different reason.
Signed-off-by: aarora4 <lazyc78@gmail.com>
Signed-off-by: aarora4 lazyc78@gmail.com
Checked by Michael Roffo