Bug/MVD-947v2 Plugin Defintion Validation #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Gerstel <tim.gerstel@gmail.com>
Signed-off-by: Timothy Gerstel <tim.gerstel@gmail.com>
ghost
assigned 
1000TurquoisePogs
approved these changes
Dec 31, 2018
There was a problem hiding this comment.
I'm OK with these additions, which will help unblock other validation needs. However in the future the loading of schemas must be dynamic to accomodate revisions in plugin api schema. I noted this in #18 . the server will later need to be flexible in matching apiVersion of a plugin with a schema on-disk that has it, so that we can validate apiVersion 1.0.1, 1.1.0, and so on.
|
I'm not ready to merge this yet since zlux-workflow doesn't conform to the schema: it's using some legacy dataservice code which needs a quick fix. |
|
Sadly this work never went in but is about to become irrelevant due to accomplishing this same work via config manager, so we'll revisit soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces pull request #18. New pull request was required due to temporarily unrelated branch histories.
From #18:
"Validates plugin definitions using the AJV package which allows for the creation of JSON schemas.
Replaces this pull request: #33
The following must be merged with this pull request:
gizafoundation/zosmf-auth#3
gizafoundation/workshop-user-browser-app#5
Potential TODO: Have warnings logged instead of errors thrown for certain validation failures (i.e. semantic versioning)
(note from rpenny)
According to the above text, this replaces pull #24 . That PR indicated committing these other PR's so I am listing them here before I close #24.:
DO NOT MERGE THIS FILE WITHOUT ALSO MERGING:
gizafoundation/zosmf-auth#3
gizafoundation/sample-app#9
gizafoundation/tn3270-ng2#10
gizafoundation/zlux-app-manager#35
gizafoundation/zos-subsystems#3
gizafoundation/zss-auth#3
gizafoundation/zlux-shared#6
gizafoundation/sample-iframe-app#3
gizafoundation/workshop-starter-app#2
gizafoundation/workshop-user-browser-app#5
EVERYTHING MUST BE MERGED AT THE SAME TIME,"