Configure zosmf-auth plugin during installation

[stevenhorsman]

@jthyssenrocket commented on Mon Feb 10 2020

The zosmf-auth plugin is enabled by default but requires configuration by updating z/OSMF host and port in remote.json

Since the installer already provides the z/OSMF host and port during installation I suggest automatically updating z/OSMF auth remote.json.

If not configured warning message will be shown in the Zowe STC output which may confuse users:

2020-02-07 16:00:45.780 <ZWED:83953919> ZIZUPUR WARN (_zsf.install,index.js:220) Exception occurred, plugin (org.zowe.zlux.proxy.zosmf) installation skipped. Message: Proxy (org.zowe.zlux.proxy.zosmf:data) setup failed.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                
 Host & Port for proxy destination are required but were missing.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           
 For information on how to configure a proxy service, see the Zowe wiki on dataservices (https://github.com/zowe/zlux/wiki/ZLUX-Dataservices)        

---

@jplinardon commented on Mon Feb 10 2020

@Joe-Winchester, @stevenhorsman I don't see you as watcher on this repo, so FYI for planning/scheduling.
@1000TurquoisePogs FYI if the WebUI squad needs to do the work.

[1000TurquoisePogs]

This plugin requires configuration that is unnecessary these days, because apiml supports zosmf anyway. This does not do anything that apiml auth does not also do.

Should we instead just remove this as a default plugin? We can still ship it, just not registered into the server.

It is much easier to install plugins before, now that we have a script, so people can add it back easily. The reason why we pre-installed it was to avoid that step that used to be hard.

[jplinardon]

We should not require unnecessary steps. Let's remove as a default plugin if no known application requires it.

[1000TurquoisePogs]

Sure. Here's the difference:

Today (1.9):

• Startup gives warning about unconfigured plugin
• You must edit 2 config files to configure the plugin, but only if you want to use it

This PR: zowe/zowe-install-packaging#1190

• The plugin exists but is not registered
• If you want to use it, you must run $INSTANCE_DIR/bin/install-app.sh $ROOT_DIR/components/app-server/share/zosmf-auth
• Then you must configure it, unless you want the same warnings 😃

So essentially this trades off 1 extra step for no more warning. AFAIK nobody needs this step currently. This plugin only makes zosmf the authentication provider, but apiml already uses zosmf as the authentication provider, so its redundant.