Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate app-server config to default.yaml - based config via configmgr #914

Closed
1000TurquoisePogs opened this issue Sep 30, 2022 · 1 comment
Assignees

Comments

@1000TurquoisePogs
Copy link
Member

Currently, app-server determines its config via:

  • zowe.yaml which the user actually edited
  • env vars
  • cli args
  • convert-env.sh which sets things via sensing conditions on the env vars
  • zluxArgs.js hardcoded defaults

in particular, convert-env.sh has a lot of weird and complicated conditions with plenty of backward compatibility.

zss had similarly complexity and has been reduced to just

  • zowe.yaml
  • defaults.yaml packaged within zss

we should

  • cut out convert-env.sh
  • remove zluxArgs.js hardcoded defaults
  • stop reading env vars directly within the zlux-server-framework code
  • add a defaults.yaml which has allll the conditionals we need to do the same sorts of actions found in those, except REMOVE v1 compatibility because it does not make sense in the v2 codebase!

here's how zss does conditionals in defaults.yaml
https://github.com/zowe/zss/blob/v2.x/staging/defaults.yaml

@1000TurquoisePogs
Copy link
Member Author

This was complete in v2.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant