Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating workflows and adding templates #12

Merged
merged 10 commits into from
May 15, 2023
Merged

updating workflows and adding templates #12

merged 10 commits into from
May 15, 2023

Conversation

ATorrise
Copy link
Contributor

@ATorrise ATorrise commented May 8, 2023

Action Description
#1 add stale bot
#2 add auto-comment bot on labels
#3 add issue template (Bug, Feature)
#4 add PR Template
#5 add question redirect
#6 update all workflows to remove deprecation warnings, octorelease updates
#7 remove Node 14 from workflow matrix

Signed-off-by: Amber Torrise <at895452@broadcom.net>
@ATorrise ATorrise self-assigned this May 8, 2023
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating even commented out steps.
Left a few comments 😋

.github/workflows/changelog.yml Outdated Show resolved Hide resolved
.github/workflows/zowe-cli-plugin.yml Outdated Show resolved Hide resolved
Signed-off-by: Amber Torrise <112635587+ATorrise@users.noreply.github.com>
Signed-off-by: Amber Torrise <112635587+ATorrise@users.noreply.github.com>
.github/workflows/zowe-cli-plugin.yml Outdated Show resolved Hide resolved
Signed-off-by: Amber Torrise <112635587+ATorrise@users.noreply.github.com>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes LGTM!
I'm not sure I know how to debug the failing system tests 😓

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that the following PR is merged, I believe we can update the workflows to make sure there is a namespace when setting up the cluster

I believe @t1m0thyj may have some recommendations here

@t1m0thyj
Copy link
Member

now that the following PR is merged, I believe we can update the workflows to make sure there is a namespace when setting up the cluster

I believe @t1m0thyj may have some recommendations here

Adding this step to the workflow in between "Start K3s Cluster" and "Create System Test Properties" should fix it (source):

            - name: Set K8s Namespace
              if: ${{ always() && steps.k3s.outcome == 'success' }}
              run: kubectl config set-context --current --namespace=default

Signed-off-by: Amber Torrise <112635587+ATorrise@users.noreply.github.com>
@ATorrise ATorrise requested a review from zFernand0 May 12, 2023 19:31
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts
image

ATorrise and others added 5 commits May 15, 2023 09:19
Signed-off-by: Amber Torrise <112635587+ATorrise@users.noreply.github.com>
Signed-off-by: Amber Torrise <112635587+ATorrise@users.noreply.github.com>
Signed-off-by: Amber Torrise <112635587+ATorrise@users.noreply.github.com>
…editor

Signed-off-by: Amber Torrise <at895452@broadcom.net>
Signed-off-by: Amber Torrise <at895452@broadcom.net>
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ATorrise!

Created a separate issue for the failure to upload test results: #14

@t1m0thyj t1m0thyj merged commit bd43346 into main May 15, 2023
13 of 14 checks passed
@t1m0thyj t1m0thyj deleted the updatingWorkFlows branch May 15, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants