Add freebsd as target for Library error #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adam-wolfe <122040687+adam-wolfe@users.noreply.github.com>
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
traeok
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
code LGTM, thanks for addressing this @adam-wolfe! I will verify this fix once my FreeBSD VM is ready (taking a while to download the image).
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok
force-pushed
the
freebsd-cargo-build-fix
branch
from
180e89d
to
869dab9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
traeok
added
the
release-patch
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Resolves #1806
How to Test
Attempt to build the Secrets SDK under FreeBSD.
Review Checklist
I certify that I have:
Additional Comments