Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Newline Normalization on Upload (V2) #1818

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fix Newline Normalization on Upload (V2) #1818

merged 1 commit into from
Oct 5, 2023

Conversation

awharn
Copy link
Member

@awharn awharn commented Oct 5, 2023

What It Does
Resolves #1815 in Zowe CLI V2

How to Test

Review Checklist
I certify that I have:

Additional Comments

@awharn
Update Imperative version
039f7d8 
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

zFernand0
zFernand0 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 merged commit cc02765 into master Oct 5, 2023
20 checks passed
@zFernand0 zFernand0 deleted the update-imperative branch October 5, 2023 19:29
@zFernand0 zFernand0 added the release-patch Indicates a patch to existing code has been applied label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Release succeeded for the master branch. 🎉

The following packages have been published:

  • npm: @zowe/cli-test-utils@7.18.7
  • npm: @zowe/core-for-zowe-sdk@7.18.7
  • npm: @zowe/zos-uss-for-zowe-sdk@7.18.7
  • npm: @zowe/provisioning-for-zowe-sdk@7.18.7
  • npm: @zowe/zos-console-for-zowe-sdk@7.18.7
  • npm: @zowe/zos-files-for-zowe-sdk@7.18.7
  • npm: @zowe/zos-logs-for-zowe-sdk@7.18.7
  • npm: @zowe/zosmf-for-zowe-sdk@7.18.7
  • npm: @zowe/zos-workflows-for-zowe-sdk@7.18.7
  • npm: @zowe/zos-jobs-for-zowe-sdk@7.18.7
  • npm: @zowe/zos-tso-for-zowe-sdk@7.18.7
  • npm: @zowe/cli@7.18.7

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t1m0thyj t1m0thyj t1m0thyj approved these changes

@gejohnston gejohnston gejohnston approved these changes

@zFernand0 zFernand0 zFernand0 approved these changes

@traeok traeok Awaiting requested review from traeok

@KevinLoesch1 KevinLoesch1 Awaiting requested review from KevinLoesch1

@ATorrise ATorrise Awaiting requested review from ATorrise

Assignees
No one assigned
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Newlines Not Normalized on (64kB) Chunk Boundaries
4 participants
@awharn @t1m0thyj @gejohnston @zFernand0