Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsonschema to newer version #1823

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Update jsonschema to newer version #1823

merged 3 commits into from
Oct 16, 2023

Conversation

awharn
Copy link
Member

@awharn awharn commented Oct 16, 2023

What It Does
Updates the jsonschema dependency to a newer version

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@@ -102,6 +102,7 @@ imperative_debug.log
# Licenses in package folders (managed with build scripts)
packages/*/LICENSE
zowex/
packages/secrets/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for gitignoring this directory.
it was kind of a pain to have to remove it whenever you switch back and forth between v2 and v1 😋

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@awharn awharn merged commit 7190395 into zowe-v1-lts Oct 16, 2023
16 checks passed
@awharn awharn deleted the update-jsonschema branch October 16, 2023 19:26
@awharn awharn restored the update-jsonschema branch October 16, 2023 19:26
@awharn awharn deleted the update-jsonschema branch October 16, 2023 19:26
@github-actions
Copy link

Release failed for the zowe-v1-lts branch. 😢

TypeError: Cannot convert undefined or null to object
    at Function.entries (<anonymous>)
    at filterPkgs (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/npm.js:1700:45)
    at pruneShrinkwrap (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/npm.js:1707:3)
    at /home/runner/work/_actions/zowe-actions/octorelease/v1/dist/npm.js:1648:7
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/zowe-actions/octorelease/v1/dist/npm.js:36:24)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Check the workflow run for more error details.

Powered by Octorelease 🚀

@zFernand0 zFernand0 added the release-current Indicates that there is no new functionality being delivered label Oct 19, 2023
@github-actions
Copy link

Release succeeded for the zowe-v1-lts branch. 🎉

The following packages have been published:

  • npm: @zowe/cli@6.40.21

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-current Indicates that there is no new functionality being delivered released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants