Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default base profile missing in config generated by auto-init #2084

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

t1m0thyj
Copy link
Member

What It Does

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.07%. Comparing base (543a1c8) to head (8e02751).
Report is 2 commits behind head on master.

Files Patch % Lines
...s/cli/src/config/auto-init/ApimlAutoInitHandler.ts 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2084      +/-   ##
==========================================
- Coverage   91.07%   91.07%   -0.01%     
==========================================
  Files         636      636              
  Lines       18965    18976      +11     
  Branches     3910     3867      -43     
==========================================
+ Hits        17272    17282      +10     
- Misses       1692     1693       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t1m0thyj t1m0thyj marked this pull request as ready for review March 11, 2024 14:49
Copy link

sonarcloud bot commented Mar 11, 2024

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and working as expected. LGTM, thanks @t1m0thyj

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 merged commit 6778da5 into master Mar 11, 2024
20 checks passed
@zFernand0 zFernand0 deleted the fix/auto-init-missing-default-base branch March 11, 2024 19:34
@t1m0thyj t1m0thyj added the release-patch Indicates a patch to existing code has been applied label Mar 11, 2024
Copy link

Release succeeded for the master branch. 🎉

The following packages have been published:

  • npm: @zowe/cli@7.23.5

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

None yet

7 participants