Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated description of overwrite (create workflow CLI) #315

Merged
merged 3 commits into from Apr 10, 2019
Merged

Updated description of overwrite (create workflow CLI) #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1419c5
Updated description of overwrite (create workflow CLI)
muzikovam Apr 8, 2019
a43272d
Updated integration snapshots
muzikovam Apr 8, 2019
1430031
Merge branch 'lts-incremental' into CreateWFupdate
zFernand0 Apr 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...cli/create/dataset/__snapshots__/cli.workflows.create.workflowDs.integration.test.ts.snap
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 3 additions & 4 deletions ...li/create/ussfile/__snapshots__/cli.workflows.create.workflowUss.integration.test.ts.snap
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...workflows/__tests__/cli/create/dataset/__snapshots__/Dataset.definition.unit.test.ts.snap
View file
Open in desktop
Expand Up @@ -110,7 +110,7 @@ Object {
"aliases": Array [
"ov",
],
"description": "Specifies whether the workflow with the same name should be deleted if it already exists.",
"description": "Replaces an existing workflow with a new workflow. ",
"name": "overwrite",
"required": false,
"type": "boolean",
Expand Down
2 changes: 1 addition & 1 deletion ...workflows/__tests__/cli/create/ussfile/__snapshots__/UssFile.definition.unit.test.ts.snap
View file
Open in desktop
Expand Up @@ -110,7 +110,7 @@ Object {
"aliases": Array [
"ov",
],
"description": "Specifies whether the workflow with the same name should be deleted if it already exists.",
"description": "Replaces an existing workflow with a new workflow. ",
"name": "overwrite",
"required": false,
"type": "boolean",
Expand Down
3 changes: 3 additions & 0 deletions packages/workflows/src/api/Create.ts
View file
Open in desktop
Expand Up @@ -95,6 +95,9 @@ export class CreateWorkflow{
deleteCompletedJobs: DeleteCompletedJobs,
};
if (!isNullOrUndefined(VariableInputFile)){
if (VariableInputFile.charAt(0) === "/" && VariableInputFile.charAt(1) === "/") {
VariableInputFile = VariableInputFile.substring(1);
}
data.variableInputFile = VariableInputFile;
}
if (!isNullOrUndefined(Variables)){
Expand Down
2 changes: 1 addition & 1 deletion packages/workflows/src/cli/create/Create.common.options.ts
View file
Open in desktop
Expand Up @@ -137,7 +137,7 @@ export const CreateCommonOptions: { [key: string]: ICommandOptionDefinition } =
overwrite: {
name: "overwrite",
aliases: ["ov"],
description: "Specifies whether the workflow with the same name should be deleted if it already exists.",
description: "Replaces an existing workflow with a new workflow. ",
type: "boolean",
required: false
},
Expand Down