Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Typescript and other package versions #633

Merged
merged 19 commits into from
Jan 13, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jan 10, 2020

When verifying that the system tests still pass after making these changes, it was discovered there were a few that failed on Linux, which were fixed.

awharn and others added 17 commits December 12, 2019 18:50
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@ghost ghost requested review from gejohnston, zFernand0 and awharn January 10, 2020 22:21
@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #633 into master will increase coverage by 0.02%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
+ Coverage   90.35%   90.38%   +0.02%     
==========================================
  Files         317      321       +4     
  Lines        4499     4522      +23     
  Branches      613      614       +1     
==========================================
+ Hits         4065     4087      +22     
- Misses        432      433       +1     
  Partials        2        2
Impacted Files Coverage Δ
packages/zosfiles/src/cli/-strings-/en.ts 100% <ø> (ø) ⬆️
packages/zosfiles/src/cli/ZosFiles.definition.ts 100% <100%> (ø) ⬆️
packages/zosfiles/src/cli/ZosFiles.utils.ts 100% <100%> (ø)
packages/zosfiles/src/cli/copy/ds/Ds.handler.ts 100% <100%> (ø)
packages/zosfiles/src/cli/copy/Copy.definition.ts 100% <100%> (ø)
packages/zosfiles/src/cli/copy/ds/Ds.definition.ts 75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef9f52...afbccd2. Read the comment docs.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 👍
Left a couple of questions : )

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zFernand0 zFernand0 merged commit 54554e3 into master Jan 13, 2020
@zFernand0 zFernand0 deleted the modify-packages branch January 13, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants