-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anton/contribute create dataset #110
Anton/contribute create dataset #110
Conversation
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Codecov ReportBase: 63.49% // Head: 64.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next #110 +/- ##
==========================================
+ Coverage 63.49% 64.11% +0.61%
==========================================
Files 28 28
Lines 967 1006 +39
==========================================
+ Hits 614 645 +31
- Misses 353 361 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the create_default_data_set
method, I think it will be very useful 👍
Left a comment 🙂 Could you please also update this PR with the "next" branch to resolve conflicts?
…thon-sdk into anton/contribute-create-dataset Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that create_default_data_set
is super useful! 🥳
Thanks @t1m0thyj for helping me understand what was happening
Left a comment which I hope makes sense 😋
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the failing unit test 🙂
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
…thon-sdk into anton/contribute-create-dataset Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
funny how this commit (ac9e6a5) doesn't show any changes if you hide whitespaces when reviewing it 😋
LGTM!
Signed-off-by: Anton Delchev dlchv.mail@gmail.com