Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anton/contribute create dataset #110

Merged
merged 12 commits into from
Sep 1, 2022

Conversation

antondelchev
Copy link
Contributor

Signed-off-by: Anton Delchev dlchv.mail@gmail.com

Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Base: 63.49% // Head: 64.11% // Increases project coverage by +0.61% 🎉

Coverage data is based on head (298a0bd) compared to base (a1efeed).
Patch coverage: 44.28% of modified lines in pull request are covered.

❗ Current head 298a0bd differs from pull request most recent head b9cb6a4. Consider uploading reports for the commit b9cb6a4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #110      +/-   ##
==========================================
+ Coverage   63.49%   64.11%   +0.61%     
==========================================
  Files          28       28              
  Lines         967     1006      +39     
==========================================
+ Hits          614      645      +31     
- Misses        353      361       +8     
Flag Coverage Δ
unittests 64.11% <44.28%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...zos_files/zowe/zos_files_for_zowe_sdk/constants.py 100.00% <ø> (ø)
src/zos_files/zowe/zos_files_for_zowe_sdk/files.py 38.72% <29.09%> (+3.17%) ⬆️
...os_files/zowe/zos_files_for_zowe_sdk/exceptions.py 100.00% <100.00%> (ø)
tests/unit/test_zos_files.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@t1m0thyj t1m0thyj linked an issue Aug 19, 2022 that may be closed by this pull request
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the create_default_data_set method, I think it will be very useful 👍

Left a comment 🙂 Could you please also update this PR with the "next" branch to resolve conflicts?

src/zos_files/zowe/zos_files_for_zowe_sdk/files.py Outdated Show resolved Hide resolved
…thon-sdk into anton/contribute-create-dataset

Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
@JTonda JTonda requested a review from zFernand0 August 29, 2022 15:10
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that create_default_data_set is super useful! 🥳
Thanks @t1m0thyj for helping me understand what was happening
Left a comment which I hope makes sense 😋

src/zos_files/zowe/zos_files_for_zowe_sdk/files.py Outdated Show resolved Hide resolved
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
@t1m0thyj t1m0thyj changed the title Related to #88 Anton/contribute create dataset Sep 1, 2022
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing unit test 🙂

Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
…thon-sdk into anton/contribute-create-dataset

Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funny how this commit (ac9e6a5) doesn't show any changes if you hide whitespaces when reviewing it 😋
LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[zos-files] create_dataset should fail if required options are missing
3 participants