Anton/contribute validate json #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Codecov ReportBase: 73.03% // Head: 63.49% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next #116 +/- ##
==========================================
- Coverage 73.03% 63.49% -9.54%
==========================================
Files 28 28
Lines 1168 967 -201
==========================================
- Hits 853 614 -239
- Misses 315 353 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
t1m0thyj
reviewed
Aug 30, 2022
…thon-sdk into anton/contribute-validate-json Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
…s for it; updated with 'next' branch. Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
boris-bc
suggested changes
Sep 12, 2022
… two test cases (valid and invalid); created invalid json files in 'fixtures' folder and removed respective variables from the test_zowe_core file. Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
boris-bc
reviewed
Sep 13, 2022
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
boris-bc
approved these changes
Sep 13, 2022
|
@antondelchev , the build is failing on unit tests. Please review and fix! |
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Signed-off-by: Anton Delchev <dlchv.mail@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validating that zowe.config.json matches zowe.schema.json. Related to #74