xplatform.loadFileUTF8 returns error for wrong file

[Martin-Zeithaml]

Proposed changes

This PR addresses Issue: #453

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

PR Checklist

Please delete options that are not relevant.

• If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
• My code follows the style guidelines of this project (see: Contributing guideline)
• I have made corresponding changes to the documentation
• New and existing unit tests pass locally with my changes
• video or image is included if visual changes are made
• Relevant update to CHANGELOG.md

[Martin-Zeithaml]

Fix seems to be working

JavaScript code

import * as xplatform from 'xplatform';
import * as fs from '/zowe/bin/libs/fs';
xplatform.loadFileUTF8(fs.createTmpFile(), xplatform.AUTO_DETECT);

Shell to run

#!/bin/sh
echo "*** 2.15.0 ***"
/zowe/2150/bin/utils/configmgr -script ./test_xplat.js
echo "*** Fix ***"
/zowe/fix/bin/utils/configmgr -script ./test_xplat.js

Output

*** 2.15.0 ***
CEE3204S The system detected a protection exception (System Completion Code=0C4).
         From compile unit ZZOW08:/ZOWE/tmp/pax-packaging-configmgr-1708462544869/content/build/../c/embeddedjs.c at entry point _outlineConc at statement 0 at compile unit offset +000000003B9038A0 at entry offset +0000000000000028 at address
         000000003B9038A0.
*** Fix ***
/tmp/zwe-2971: EDC5129I No such file or directory. (errno2=0x05620062)
TypeError: realpath failure

Fix seems to be working, but...

JavaScript code - simplified

import * as xplatform from 'xplatform';
xplatform.loadFileUTF8('./asdfasdfasdfasdfasdfasd', xplatform.AUTO_DETECT);

Shell to run - the same

#!/bin/sh
echo "*** 2.15.0 ***"
/zowe/2150/bin/utils/configmgr -script ./test_xplat.js
echo "*** Fix ***"
/zowe/fix/bin/utils/configmgr -script ./test_xplat.js

Output - different

*** 2.15.0 ***
*** Fix ***
./asdfasdfasdfasdf: EDC5129I No such file or directory. (errno2=0x05620062)
TypeError: realpath failure

[Martin-Zeithaml]

1. Removed unused variables
2. The error is the same as in xplatformAppendFileUTF8 and xplatformStoreFileUTF8
3. Different behavior probably caused by C behavior: "If an object that has automatic storage duration is not initialized explicitly, its value is indeterminate." It seems, that length was "accidentally" set to zero in one case (causing no abend) and in the other case some random value resulting in abend.

Output reduced to:

*** Fix ***
TypeError: realpath failure

[JoeNemo]

Approved.