Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USS files menu serves incorrect content from another directory #1134

Closed
ChrisBoehmCA opened this issue Jan 11, 2021 · 6 comments · Fixed by #1229
Closed

USS files menu serves incorrect content from another directory #1134

ChrisBoehmCA opened this issue Jan 11, 2021 · 6 comments · Fixed by #1229
Assignees
Labels
bug Something isn't working priority-low Legit issue but cosmetic or nice-to-have
Milestone

Comments

@ChrisBoehmCA
Copy link
Contributor

Describe the bug

To Reproduce

I am not sure exactly what causes this, but I think is the fact that I have been viewing two directories with similar structure. What happens is that once you change filters, similarly named files from a previous filter are downloaded instead of those for the active filter. It's hard to show an example since the path names are sensitive info, but here's a visual:

image

So connect to a profile and click the USS section. Try setting up these USS files.

/u/users/abc/hello/hello.log

and

/u/users/def/hello/hello.log

Try setting a filter for /u/users/def first and downloading hello/hello.log.

Then try to change your filter to /u/users/abc and try to download hello/hello.log. If this reproduction was sufficient you will see that it downloads to the /u/users/def path instead of a new path. I would guess this is caused by using the relative path as the unique identifier for a file, but the absolute path must be used instead. Either way, changing the directory or deleting the old file manually does not fix the issue. I guess restarting VS Code would be the only solution right now.

Expected behavior

The file is served from the currently selected directory instead of a previously selected one.

Screenshots

Desktop (please complete the following information):

  • OS: Windows 10
  • Zowe Explorer Version: v1.11.1
  • (Optional) Zowe CLI Version: 6.24.2
  • (Optional) Are you using Secure Credential Store? No

Additional context

@ChrisBoehmCA ChrisBoehmCA added the bug Something isn't working label Jan 11, 2021
@zdmullen
Copy link
Contributor

This could be related in part to #650 . @lauren-li will look into it.

@jellypuno jellypuno added the 21PI1 label Feb 1, 2021
@ChrisBoehmCA
Copy link
Contributor Author

I can't use Zowe Explorer unless this is fixed as the wrong files are uploaded and downloaded when I edit. Seems like the related issue changed priority a few times.

@lauren-li
Copy link
Contributor

I was debugging this, and it seems like the absolute path is actually being used; however, it is not getting updated everywhere it needs to be when running a new search. I am looking into why this is the case.

The related issue (#650) is also being worked on (and upon further investigation, does not actually seem very related). It has been moved around a bit as the Zowe Explorer squad was arranging issues in a new project board after PI planning. Apologies for the confusion there, but I am trying to get it in for the next Zowe Explorer release (1.13.0).

@ChrisBoehmCA
Copy link
Contributor Author

ChrisBoehmCA commented Mar 2, 2021 via email

@jellypuno jellypuno added the priority-low Legit issue but cosmetic or nice-to-have label Mar 2, 2021
@crawr crawr added this to the 1.13 Release milestone Mar 2, 2021
@crawr crawr added the Sprint 3 label Mar 2, 2021
@lauren-li
Copy link
Contributor

@ChrisBoehmCA This issue is being addressed by PR #1229 (Bugfix issue 1134: Add parentPath check for existing USS node children). The PR description has more details on what the root issue was and how it was fixed. Please feel free to check it out and give it a try!

@ChrisBoehmCA
Copy link
Contributor Author

Thanks for the update. If I get a chance I will try to build from source from that branch and try it out

@crawr crawr closed this as completed Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-low Legit issue but cosmetic or nice-to-have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants