Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for 1.14.0 release #1273

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Preparation for 1.14.0 release #1273

merged 2 commits into from
Apr 21, 2021

Conversation

jellypuno
Copy link
Contributor

Signed-off-by: Jessielaine Punongbayan jessielaine.punongbayan@broadcom.com

Proposed changes

Preparation for 1.14.0 release

Release Notes

Milestone:

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: Jessielaine Punongbayan <jessielaine.punongbayan@broadcom.com>
@lauren-li
Copy link
Contributor

This looks good to me! One minor question, which is tangentially related to this PR: I noticed the Changelog entry for this release says "1.14", where in previous releases we listed all 3 numbers (e.g. "1.13.0", "1.12.0"). Do we want to change it to say "1.14.0" to keep it consistent with past Changelog entries?

Additionally, should we add a 1.14.0 item in the FTP extension's Changelog, as Job functionalities were added for zFTP profiles? (Maybe these are questions for @IgorCATech.)

@jellypuno
Copy link
Contributor Author

jellypuno commented Apr 21, 2021

@lauren-li thanks for spotting that. I merged @IgorCATech PR too fast 😞

…n Changelog

Signed-off-by: Lauren Li <45975633+lauren-li@users.noreply.github.com>
@lauren-li
Copy link
Contributor

@lauren-li thanks for spotting that. I merged @IgorCATech PR too fast 😞

@jellypuno No worries! I've updated the changelogs as you requested. Thank you for coordinating this release!

Copy link
Contributor

@crawr crawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for preparing this

Copy link
Contributor

@lauren-li lauren-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @jellypuno!

@jellypuno jellypuno merged commit 15a6ef6 into master Apr 21, 2021
@jellypuno jellypuno deleted the 1.14.0-Release branch April 21, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants