Multiple delete of datasets/members #1323

katelynienaber · 2021-05-19T14:10:00Z

Proposed changes

Does what it says on the tin.

Select a bunch of data sets & members
Hit your Delete button on the keyboard
Confirm you want to delete
The data sets/members you selected are gone
If you selected favorites or profiles, they won't disappear

Release Notes

Milestone: Backlog

Changelog: Added multi-delete capability for data sets and members

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>

Also rearranged some integration tests, to match new refresh function location & name of Dataset actions file Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>

love of potato Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>

Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>

crawr

The delete works well for me with the keyboard option, but I noticed that it did not work when I tried to use the context menu Delete Data Set to delete multiple datasets and members.
Is this as expected ? Can we wrap the existing delete command to also perform multiple deletion?

Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>

katelynienaber · 2021-06-01T13:03:48Z

@crawr I forgot to check this! It should be fixed now.

JillieBeanSim

@katelynienaber I am in love with this new functionality!!! I have needed to cleanup my data sets list for some time now but deleting them 1 by 1 seemed so tedious lol.
I do have a simple request about the information pop up where it says node, could we change the wording of that to maybe The following were deleted ... or something similar?
Also, we have some failing integration tests that deal with deleting data sets that should get fixed with this PR

I am also seeing the following integration tests fail on this branch and not master so I wonder if the CLI version bump is causing another regression that will need to be addressed in a different High Priority issue.
UPDATE/EDIT: I got confused with PRs I was testing, this PR shouldn't have the CLI bump correct? Wonder why the following are failing.

Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>

katelynienaber · 2021-06-03T11:46:20Z

@JillieBeanSim For the deletion text, is The following items were deleted acceptable?

Also I removed those 2 failing deleteDataset integration tests. There is no more confirmation dialog in function deleteDataset, I have moved it into the new function deleteDatasetPrompt. That function already has unit tests covering the cancellation dialog.

katelynienaber · 2021-06-03T13:04:56Z

@JillieBeanSim I am still getting the 2nd integration test errors, is it a problem for you as well?

JillieBeanSim · 2021-06-03T17:09:58Z

@katelynienaber I am still seeing those tests that deal with patterns fail and only on this branch do I see this issue. These tests directly follow the delete test you have and they use the same testTree so I wonder if the delete is altering the testTree for the following tests.
extension.integration.test.ts

crawr

Great work on this @katelynienaber, thanks!

packages/zowe-explorer/src/dataset/actions.ts

katelynienaber · 2021-06-08T11:34:56Z

@JillieBeanSim I've fixed the integration tests, please take a look if you have time ^^

JillieBeanSim · 2021-06-08T14:56:18Z

@katelynienaber I am still getting the failures on this branch, maybe someone else could run them also and make sure it's not just my. I know these tests can be finnicky at times.

jellypuno · 2021-06-08T16:52:41Z

I have them as well.

katelynienaber · 2021-06-09T08:29:45Z

@JillieBeanSim @jellypuno Could you give me more info about the failures? Because they are passing for me:

jellypuno · 2021-06-09T08:34:44Z

Can you show me your testProfileData.ts? Mask your credentials

jellypuno · 2021-06-09T09:31:25Z

@katelynienaber I'm having an error here const childrenFromTree = await sessionNode.getChildren(); 404 error for CREATE.DATASET

jellypuno · 2021-06-09T09:39:25Z

I am running the pre-test and post-test before executing integration

jellypuno · 2021-06-09T14:14:00Z

@JillieBeanSim Katelyn and I have been investigating this one and it is a really tricky issue. I think we would need more time to investigate. If it is okay with you, Can we merge this PR and then follow-up on a fix for that integration test?

JillieBeanSim · 2021-06-09T18:38:24Z

@JillieBeanSim Katelyn and I have been investigating this one and it is a really tricky issue. I think we would need more time to investigate. If it is okay with you, Can we merge this PR and then follow-up on a fix for that integration test?

@jellypuno @katelynienaber that should be fine. I will test functionality again this afternoon and if none of that changed from before throw my approval on it. Should an issue be created for handling the integration tests or just wing it?

jellypuno · 2021-06-09T18:40:01Z

@katelynienaber please open an issue for the integration for tracking.

katelynienaber · 2021-06-10T08:11:30Z

@jellypuno @JillieBeanSim here is the issue for the integration tests. I will try to get to them in that weird 4-day week I have after this sprint, before I go on vacation. If nothing else comes up.

JillieBeanSim · 2021-06-10T11:25:24Z

@katelynienaber deleting multiple data sets works well with right-click and keyboard , but multiple delete of members doesn't remove the members from the tree until the data set is closed then re-opened. I see these errors below in the debug console for each member

Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>

katelynienaber · 2021-06-23T08:57:02Z

@JillieBeanSim I added a fix for this, please take a look ^^

JillieBeanSim · 2021-06-24T12:56:24Z

Thanks @katelynienaber! All LGTM with the update to handle the members being removed from the tree as well during the deletion. This multi-delete action is so awesome!! Thanks for getting this done for us

crawr

LGTM. Thanks @katelynienaber

Working, but I can't create datasets on which to test it???

9059457

Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>

katelynienaber added enhancement New feature or request backlog in progress UX Datasets labels May 19, 2021

katelynienaber added this to the Backlog milestone May 19, 2021

katelynienaber self-assigned this May 19, 2021

New functionality working, adding unit/integration tests

d9380b1

Also rearranged some integration tests, to match new refresh function location & name of Dataset actions file Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>

katelynienaber changed the title ~~Multiple delete for datasets/members~~ Multiple delete of datasets/members May 20, 2021

katelynienaber and others added 3 commits May 20, 2021 15:39

Why tf is deleteDatasetSpy not recording calls to the function? For the

fc85e14

love of potato Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>

Unit tests added

bd2731d

Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>

Merge branch 'master' into multi-delete

f2ff9b6

katelynienaber marked this pull request as ready for review May 25, 2021 09:11

Merge branch 'master' into multi-delete

e07b39e

crawr reviewed Jun 1, 2021

View reviewed changes

Fixes for Richelle's comments

4ba8e19

Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>

crawr requested a review from lauren-li June 1, 2021 14:39

JillieBeanSim self-requested a review June 2, 2021 19:58

JillieBeanSim requested changes Jun 2, 2021

View reviewed changes

Merge branch 'master' into multi-delete

f93042b

katelynienaber mentioned this pull request Jun 3, 2021

Multi-selection support for all applicable functionalities #1286

Closed

Fixes for Billie

8a45eb2

Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>

crawr previously approved these changes Jun 4, 2021

View reviewed changes

packages/zowe-explorer/src/dataset/actions.ts Show resolved Hide resolved

Merge branch 'master' into multi-delete

d4fb4b9

crawr removed this from the Backlog milestone Jun 7, 2021

Merge branch 'master' into multi-delete

2f4594f

jellypuno unassigned katelynienaber Jun 9, 2021

zowe deleted a comment from katelynienaber Jun 9, 2021

crawr removed this from the 1.16.0 Release milestone Jun 10, 2021

katelynienaber added 3 commits June 22, 2021 15:25

Merge branch 'master' into multi-delete

ee68fb1

Merge branch 'master' into multi-delete

6bd01d9

Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>

Fixes for Billie

f46022f

Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>

katelynienaber requested review from JillieBeanSim and crawr June 22, 2021 15:03

JillieBeanSim approved these changes Jun 24, 2021

View reviewed changes

crawr added this to the 1.17.0 Release milestone Jun 24, 2021

crawr approved these changes Jun 24, 2021

View reviewed changes

crawr merged commit d4068ed into master Jun 24, 2021

crawr deleted the multi-delete branch June 24, 2021 13:25

katelynienaber restored the multi-delete branch July 27, 2021 13:59

zFernand0 deleted the multi-delete branch February 11, 2022 12:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple delete of datasets/members #1323

Multiple delete of datasets/members #1323

katelynienaber commented May 19, 2021 •

edited

crawr left a comment

katelynienaber commented Jun 1, 2021

JillieBeanSim left a comment •

edited

katelynienaber commented Jun 3, 2021 •

edited

katelynienaber commented Jun 3, 2021

JillieBeanSim commented Jun 3, 2021 •

edited

crawr left a comment

katelynienaber commented Jun 8, 2021

JillieBeanSim commented Jun 8, 2021

jellypuno commented Jun 8, 2021

katelynienaber commented Jun 9, 2021

jellypuno commented Jun 9, 2021

jellypuno commented Jun 9, 2021

jellypuno commented Jun 9, 2021

jellypuno commented Jun 9, 2021

JillieBeanSim commented Jun 9, 2021

jellypuno commented Jun 9, 2021

katelynienaber commented Jun 10, 2021 •

edited

JillieBeanSim commented Jun 10, 2021

katelynienaber commented Jun 23, 2021

JillieBeanSim commented Jun 24, 2021

crawr left a comment

Multiple delete of datasets/members #1323

Multiple delete of datasets/members #1323

Conversation

katelynienaber commented May 19, 2021 • edited

Proposed changes

Release Notes

Types of changes

Checklist

crawr left a comment

Choose a reason for hiding this comment

katelynienaber commented Jun 1, 2021

JillieBeanSim left a comment • edited

Choose a reason for hiding this comment

katelynienaber commented Jun 3, 2021 • edited

katelynienaber commented Jun 3, 2021

JillieBeanSim commented Jun 3, 2021 • edited

crawr left a comment

Choose a reason for hiding this comment

katelynienaber commented Jun 8, 2021

JillieBeanSim commented Jun 8, 2021

jellypuno commented Jun 8, 2021

katelynienaber commented Jun 9, 2021

jellypuno commented Jun 9, 2021

jellypuno commented Jun 9, 2021

jellypuno commented Jun 9, 2021

jellypuno commented Jun 9, 2021

JillieBeanSim commented Jun 9, 2021

jellypuno commented Jun 9, 2021

katelynienaber commented Jun 10, 2021 • edited

JillieBeanSim commented Jun 10, 2021

katelynienaber commented Jun 23, 2021

JillieBeanSim commented Jun 24, 2021

crawr left a comment

Choose a reason for hiding this comment

katelynienaber commented May 19, 2021 •

edited

JillieBeanSim left a comment •

edited

katelynienaber commented Jun 3, 2021 •

edited

JillieBeanSim commented Jun 3, 2021 •

edited

katelynienaber commented Jun 10, 2021 •

edited