Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error string fix for profile not found in favorites #1344

Closed
wants to merge 7 commits into from

Conversation

rudyflores
Copy link
Contributor

@rudyflores rudyflores commented Jun 3, 2021

Signed-off-by: Rudy Flores 68666202+rudyflores@users.noreply.github.com

Proposed changes

Corrections for error message string displayed upon triggering an error when trying to access a profile on the favorites folder for datasets, USS, and jobs. #791

Screen Shot 2021-06-04 at 9 26 08 AM

Screen Shot 2021-06-04 at 8 54 32 AM

Screen Shot 2021-06-04 at 9 26 21 AM

Release Notes

Milestone: Release v1.16.0
Changelog: correction to error message string when accessing a profile in the favorites section.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
… and data sets

Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
@rudyflores rudyflores force-pushed the error-string-fix branch 2 times, most recently from 911921b to b7538b8 Compare June 7, 2021 14:30
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
@rudyflores rudyflores requested a review from lauren-li June 7, 2021 15:47
@crawr crawr added this to the 1.16.0 Release milestone Jun 7, 2021
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
@rudyflores
Copy link
Contributor Author

Closing in favor of #1349

@rudyflores rudyflores closed this Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants