Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1206: automatically add missing job profile #1386

Merged
merged 6 commits into from Jul 15, 2021
Merged

Issue #1206: automatically add missing job profile #1386

merged 6 commits into from Jul 15, 2021

Conversation

nickImbirev
Copy link
Contributor

@nickImbirev nickImbirev commented Jul 9, 2021 •
edited

Proposed changes

Automatically add missing jobs session into jobs tree during focusing on submitted job.

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)
Screen.Recording.2021-07-09.at.15.37.31.mov

Nikolai Imbirev added 4 commits July 9, 2021 10:28
implement focusOnJob command handler
e0c11dd 
Signed-off-by: Nikolai Imbirev <nikolay.imbirev@broadcom.com>
switch setJobSpool command to a new handler
41d0b59 
Signed-off-by: Nikolai Imbirev <nikolay.imbirev@broadcom.com>
Merge branch 'master' into feat-1266/auto-add-missing-job-profile
1cc680c
fix refreshing sessions on job focus
efad14e 
Signed-off-by: Nikolai Imbirev <nikolay.imbirev@broadcom.com>
@nickImbirev nickImbirev added the enhancement New feature or request label Jul 9, 2021
@nickImbirev nickImbirev linked an issue Jul 9, 2021 that may be closed by this pull request
Automatically add the needed profile if I click the jobID #1206
Closed
@nickImbirev nickImbirev changed the title Issue #1266: automatically add missing job profile Issue #1206: automatically add missing job profile Jul 9, 2021
implement unit tests for a new focusOnJob handler
3913b27 
Signed-off-by: Nikolai Imbirev <nikolay.imbirev@broadcom.com>
@nickImbirev nickImbirev marked this pull request as ready for review July 9, 2021 13:35
jellypuno
jellypuno approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@jellypuno jellypuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please test it in Theia as well. Thank you for adding this @nickImbirev !

@crawr crawr requested a review from JillieBeanSim July 13, 2021 14:44
@crawr crawr added this to the 1.17.0 Release milestone Jul 13, 2021
JillieBeanSim
JillieBeanSim approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All expected tests and checks are passing. Thanks @nickImbirev for this, I am glad we finally have this enhancement =)

@crawr crawr merged commit 73f167b into master Jul 15, 2021
@crawr crawr deleted the feat-1266/auto-add-missing-job-profile branch July 15, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jellypuno jellypuno jellypuno approved these changes

@JillieBeanSim JillieBeanSim JillieBeanSim approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.17.0 Release
Development

Successfully merging this pull request may close these issues.

Automatically add the needed profile if I click the jobID
4 participants
@nickImbirev @jellypuno @JillieBeanSim @crawr