Provide profiles cache to extenders #1390
Conversation
Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com>
Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com>
Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com>
Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com>
|
If there is no other feedback the this one is ready to be merged. |
There was a problem hiding this comment.
This looks good to me so far! The sample code with the Zowe Explorer FTP extension is working well in manual testing, and all unit tests are passing. (My integration tests are still acting up even on master branch, so Billie will have to help me out with those.)
As mentioned in the code comments, the sample code in the FTP extension should be removed before merging. I am also curious what @AndrewTwydell's experience was using the changes/documentation in this PR with the Zowe Explorer CICS extension. From my discussion with him earlier, it seems he had a positive experience, but Andrew feel free to comment and keep me honest! 😄
Thanks @phaumer for making Zowe Explorer's profilesCache available to extenders!
Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com>
|
@lauren-li thanks for reminding me. I removed the sample code now. |
|
Getting the following error when using a local copy of the zowe-explorer-api dependency in the following format:
FYI - @phaumer @lauren-li |
|
@AndrewTwydell this might not be the reason, but when you create a local build to load as a file I would update the version number to make sure your version actually replaces actually the published version in your node_modules. |
Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com>
…ion-for-zowe into profiles-cache-access
|
@AndrewTwydell I think I found the issue and added a commit. Can you try again? |
|
@phaumer I'm no longer getting the error, all good now 😄 Thanks for all your work on this, it really makes extending with the CICS Explorer so much easier! |
There was a problem hiding this comment.
LGTM!
Really appreciate this work - it's made profile access so much easier, so thank you!
Final question... We discussed adding the functionality to tell the profile cache to load other profile types (CICS in our case). I assume this will be done at a later date and not included in this PR?
There was a problem hiding this comment.
LGTM! Thanks for your work on this @phaumer. All expected tests and checks are also passing =)
Signed-off-by: Lauren Li <45975633+lauren-li@users.noreply.github.com>
lauren-li
dismissed stale reviews from JillieBeanSim and AndrewTwydell
via
a95a12a
There was a problem hiding this comment.
This looks good to me now! I added some minor edits to the docs/code sample (it was missing a }), but the functionality is still working well, and all unit and expected integration tests are still passing.
Thanks @phaumer for the fix, and thanks @AndrewTwydell for testing this out with the CICS extension!
Signed-off-by: Peter Haumer 4391934+phaumer@users.noreply.github.com
Proposed changes
First implementation for #1281. Builds on PR #1290.
See packages/zowe-explorer-ftp-extension/src/extension.ts for example for how to use it.
Release Notes
Milestone:
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublishhas been executedFurther comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...