Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1403: Ensure status icons are reset when refreshing view #1404

Merged
merged 1 commit into from Jul 27, 2021

Conversation

lauren-li
Copy link
Contributor

@lauren-li lauren-li commented Jul 22, 2021

Proposed changes

Fixes issue #1403 (Refresh view does not consistently reset profile status).
(See issue for recreate/testing steps.)

Gif of fix:

ze-refreshIconsFix

Release Notes

Milestone: 1.17.1 hotfix or 1.18.0

Changelog: Ensure status icons are reset when refreshing views

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: Lauren Li <45975633+lauren-li@users.noreply.github.com>
@lauren-li lauren-li changed the title Issue 14013: Ensure status icons are reset when refreshing view Issue 1403: Ensure status icons are reset when refreshing view Jul 22, 2021
@lauren-li lauren-li linked an issue Jul 22, 2021 that may be closed by this pull request
Copy link
Contributor

@katelynienaber katelynienaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (as per conversation on the issue ^^)

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lauren-li for addressing this. All expected tests and checks are passing

@crawr crawr merged commit c5f53f4 into master Jul 27, 2021
@crawr crawr deleted the refresh-icons branch July 27, 2021 15:14
@JillieBeanSim JillieBeanSim added this to the v1.18.0 milestone Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh view does not consistently reset profile status
4 participants