Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Create/Update Profile Esc Error on Host Input #1426

Merged
merged 11 commits into from Aug 5, 2021

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Aug 3, 2021

Proposed changes

Bug fix to return expected error message No valid value for z/OS URL. Operation Cancelled instead of shown error when a user escapes the host text box during creation or updating of a profile.

image

Release Notes

Milestone: 1.18

Changelog: Bug fix to return expected error message No valid value for z/OS URL. Operation Cancelled instead of shown error when a user escapes the host text box during creation or updating of a profile.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

GIF

create-update-esc-fix

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim JillieBeanSim added the bug Something isn't working label Aug 3, 2021
@JillieBeanSim JillieBeanSim added this to the v1.18.0 milestone Aug 3, 2021
@JillieBeanSim JillieBeanSim self-assigned this Aug 3, 2021
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim JillieBeanSim linked an issue Aug 3, 2021 that may be closed by this pull request
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@jellypuno
Copy link
Contributor

@JillieBeanSim dataset and jobs is also fixed? They are experiencing this problem as well

@JillieBeanSim
Copy link
Contributor Author

JillieBeanSim commented Aug 3, 2021

@JillieBeanSim dataset and jobs is also fixed? They are experiencing this problem as well

@jellypuno where is this happening in datasets and jobs? This fix will be reflected in Create and Update profile across all trees.

lauren-li
lauren-li previously approved these changes Aug 3, 2021
Copy link
Contributor

@lauren-li lauren-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me! In manual testing, it got rid of the errors I was seeing in 1.17.0 when cancelling in the middle of updating a profile, and also provided the appropriate info message when cancelling in the middle of creating a profile. This was true for all three views (Data Sets, USS, and Jobs). All unit tests are passing. My integration tests are still acting up, but @JillieBeanSim was kind enough to run them for me and show that all expected integration tests were passing. (@jellypuno feel free to double-check behind us!)

Thanks @JillieBeanSim for this fix!

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Copy link
Contributor

@lauren-li lauren-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me still! Thanks @JillieBeanSim for the fix!

@crawr crawr self-requested a review August 5, 2021 13:47
Copy link
Contributor

@crawr crawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested this manually and the functionality works for me. Theia tests also passed for me locally. Thanks @JillieBeanSim

@crawr crawr merged commit 08326b6 into master Aug 5, 2021
@JillieBeanSim JillieBeanSim deleted the create-update-profile-fixes branch October 22, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create/Update Profile Error when Esc Host textbox
4 participants