New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fix: Create/Update Profile Esc Error on Host Input #1426
Conversation
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim dataset and jobs is also fixed? They are experiencing this problem as well |
@jellypuno where is this happening in datasets and jobs? This fix will be reflected in Create and Update profile across all trees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me! In manual testing, it got rid of the errors I was seeing in 1.17.0 when cancelling in the middle of updating a profile, and also provided the appropriate info message when cancelling in the middle of creating a profile. This was true for all three views (Data Sets, USS, and Jobs). All unit tests are passing. My integration tests are still acting up, but @JillieBeanSim was kind enough to run them for me and show that all expected integration tests were passing. (@jellypuno feel free to double-check behind us!)
Thanks @JillieBeanSim for this fix!
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me still! Thanks @JillieBeanSim for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I tested this manually and the functionality works for me. Theia tests also passed for me locally. Thanks @JillieBeanSim
Proposed changes
Bug fix to return expected error message
No valid value for z/OS URL. Operation Cancelled
instead of shown error when a user escapes the host text box during creation or updating of a profile.Release Notes
Milestone: 1.18
Changelog: Bug fix to return expected error message
No valid value for z/OS URL. Operation Cancelled
instead of shown error when a user escapes the host text box during creation or updating of a profile.Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedGIF