New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.19 to next (2nd go) #1509
1.19 to next (2nd go) #1509
Conversation
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
…e-extension-for-zowe into fix-integration-tests
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
…or-extenders' into imperative-logger-for-extenders
Signed-off-by: tian na <tiantn@cn.ibm.com>
Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
@JillieBeanSim Would you have any idea how to fix the failing tests here? It has to do with an NPM version it seems... |
@katelynienaber it looks like with the bringing in of master branch you are also bringing in the node 10 tests which are removed in the next branch as Node 10 is not supported anymore. |
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
removed the node 10 from GHA tests as well as node 16 like done in #1472 https://github.com/zowe/vscode-extension-for-zowe/blob/e9fb19d9e864494177dbcfa0b939ea7152ac4a13/.github/workflows/zowe-explorer-ci.yml#L19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most new functionality is working well, I do see that the FTP profile is not validating though. This is with old style profiles and if config file is created via cli and includes FTP. @lauren-li @tiantn
UPDATE: My bad, I forgot to package and install the FTP extension from this branch, all is working!
Another thing I see that could be a separate issue/PR would be that Issue TSO Command
isn't recognizing the TSO profile information like acct number from the config file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @katelynienaber for putting this together to update next with the most recent changes. I will create the issue for the TSO stuff I noticed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @katelynienaber
I did find an issue in the next
branch where the Job ID link does not work unless a search has already been performed on the profile. But this also exists outside of this PR so I will file a separate issue.
Proposed changes
Merge 1.19.0 changes into next branch for testing purposes.