Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19 to next (2nd go) #1509

Merged
merged 194 commits into from Oct 5, 2021
Merged

1.19 to next (2nd go) #1509

merged 194 commits into from Oct 5, 2021

Conversation

katelynienaber
Copy link
Contributor

Proposed changes

Merge 1.19.0 changes into next branch for testing purposes.

katelynienaber and others added 30 commits August 2, 2021 13:55
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
…or-extenders' into imperative-logger-for-extenders
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: tian na <tiantn@cn.ibm.com>
Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Peter Haumer <4391934+phaumer@users.noreply.github.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
@katelynienaber katelynienaber self-assigned this Sep 30, 2021
@katelynienaber katelynienaber changed the base branch from master to next September 30, 2021 15:07
@JillieBeanSim JillieBeanSim added this to the vNext 0.2 milestone Sep 30, 2021
@lauren-li lauren-li mentioned this pull request Sep 30, 2021
katelynienaber and others added 8 commits October 1, 2021 12:34
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
Signed-off-by: Katelyn Nienaber <katelyn.nienaber@broadcom.com>
@katelynienaber
Copy link
Contributor Author

@JillieBeanSim Would you have any idea how to fix the failing tests here? It has to do with an NPM version it seems...

@JillieBeanSim
Copy link
Contributor

JillieBeanSim commented Oct 5, 2021

@JillieBeanSim Would you have any idea how to fix the failing tests here? It has to do with an NPM version it seems...

@katelynienaber it looks like with the bringing in of master branch you are also bringing in the node 10 tests which are removed in the next branch as Node 10 is not supported anymore.

Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
@JillieBeanSim
Copy link
Contributor

removed the node 10 from GHA tests as well as node 16 like done in #1472 https://github.com/zowe/vscode-extension-for-zowe/blob/e9fb19d9e864494177dbcfa0b939ea7152ac4a13/.github/workflows/zowe-explorer-ci.yml#L19

@jellypuno jellypuno added the vNext label Oct 5, 2021
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most new functionality is working well, I do see that the FTP profile is not validating though. This is with old style profiles and if config file is created via cli and includes FTP. @lauren-li @tiantn
UPDATE: My bad, I forgot to package and install the FTP extension from this branch, all is working!

Another thing I see that could be a separate issue/PR would be that Issue TSO Command isn't recognizing the TSO profile information like acct number from the config file.

@JillieBeanSim JillieBeanSim self-requested a review October 5, 2021 13:35
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @katelynienaber for putting this together to update next with the most recent changes. I will create the issue for the TSO stuff I noticed.

Copy link
Contributor

@crawr crawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @katelynienaber

I did find an issue in the next branch where the Job ID link does not work unless a search has already been performed on the profile. But this also exists outside of this PR so I will file a separate issue.

@JillieBeanSim JillieBeanSim merged commit a996289 into next Oct 5, 2021
@JillieBeanSim JillieBeanSim deleted the 1.19-to-next-2 branch October 5, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants