Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display message in status bar #1542

Merged
merged 9 commits into from Nov 2, 2021

Conversation

anokhikastiaIBM
Copy link
Contributor

@anokhikastiaIBM anokhikastiaIBM commented Oct 20, 2021

Signed-off-by: Anokhi Kastia 90722760+anokhikastiaIBM@users.noreply.github.com

Proposed changes

[#213] Display messages in status bar

Description of the Issue: When editing a dataset in VS Code, a notification appears every time it saves that says "Dataset uploaded successfully." The frequency of these notifications seems undesirable when making a lot of edits, as they keep on popping up.

The status bar should be at the bottom of the screen instead. This would make the info less distracting, while still visible for users who want to see it.

Changes: The only change that I made was to the file action.ts on line 1358. When a file is changed, the function saveFile is called when the text document is being saved. A message "DataSet uploaded successfully" (uploadResponse.commandResponse) shows up. I changed to setStatusBarMessage.

Release Notes

Milestone:

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Reminder

After a PR is merged into the master branch, create a PR from master to the next branch resolving any conflicts.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: Anokhi Kastia <90722760+anokhikastiaIBM@users.noreply.github.com>
@anokhikastiaIBM anokhikastiaIBM marked this pull request as ready for review October 20, 2021 23:48
anokhikastiaIBM and others added 5 commits October 20, 2021 19:49
Signed-off-by: Anokhi Kastia <90722760+anokhikastiaIBM@users.noreply.github.com>
Signed-off-by: Anokhi Kastia <90722760+anokhikastiaIBM@users.noreply.github.com>
@JillieBeanSim
Copy link
Contributor

JillieBeanSim commented Oct 21, 2021

@anokhikastiaIBM I thought we were also changing the pop up notification in these two files too so Saving file... & Saving data set... wasn't popping up constantly. Changing vscode.ProgressLocation.Notification to vscode.ProgressLocation.Window
image
image

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above

rudyflores
rudyflores previously approved these changes Oct 21, 2021
Copy link
Contributor

@rudyflores rudyflores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit and integration tests seem to be passing, I have tested this enhancement in DS and USS and it also seems to be working great!

I also noticed now the status message goes away after a couple seconds of popping up in the bottom left. Awesome work! @anokhikastiaIBM

Signed-off-by: Anokhi Kastia <90722760+anokhikastiaIBM@users.noreply.github.com>
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anokhikastiaIBM for addressing my comment. Everything LGTM now and all expected tests and checks are passing.

@rudyflores rudyflores self-requested a review October 27, 2021 21:12
Copy link
Contributor

@rudyflores rudyflores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration and unit tests seem to be passing, I also tested this in the development host and edited some data sets and seems to be working as intended when both uploading and saving messages are displayed on the bottom left. Thanks for all these edits @anokhikastiaIBM !

@JillieBeanSim JillieBeanSim linked an issue Oct 27, 2021 that may be closed by this pull request
@crawr crawr merged commit 08aa6d8 into zowe:master Nov 2, 2021
@crawr crawr added this to the 1.21.0 milestone Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate displaying messages in status bar
4 participants