New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display message in status bar #1542
Conversation
Signed-off-by: Anokhi Kastia <90722760+anokhikastiaIBM@users.noreply.github.com>
Signed-off-by: Anokhi Kastia <90722760+anokhikastiaIBM@users.noreply.github.com>
…stiaIBM/vscode-extension-for-zowe into display-msg-status-bar3
Signed-off-by: Anokhi Kastia <90722760+anokhikastiaIBM@users.noreply.github.com>
@anokhikastiaIBM I thought we were also changing the pop up notification in these two files too so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit and integration tests seem to be passing, I have tested this enhancement in DS and USS and it also seems to be working great!
I also noticed now the status message goes away after a couple seconds of popping up in the bottom left. Awesome work! @anokhikastiaIBM
Signed-off-by: Anokhi Kastia <90722760+anokhikastiaIBM@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anokhikastiaIBM for addressing my comment. Everything LGTM now and all expected tests and checks are passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integration and unit tests seem to be passing, I also tested this in the development host and edited some data sets and seems to be working as intended when both uploading and saving messages are displayed on the bottom left. Thanks for all these edits @anokhikastiaIBM !
Signed-off-by: Anokhi Kastia 90722760+anokhikastiaIBM@users.noreply.github.com
Proposed changes
[#213] Display messages in status bar
Description of the Issue: When editing a dataset in VS Code, a notification appears every time it saves that says "Dataset uploaded successfully." The frequency of these notifications seems undesirable when making a lot of edits, as they keep on popping up.
The status bar should be at the bottom of the screen instead. This would make the info less distracting, while still visible for users who want to see it.
Changes: The only change that I made was to the file action.ts on line 1358. When a file is changed, the function saveFile is called when the text document is being saved. A message "DataSet uploaded successfully" (uploadResponse.commandResponse) shows up. I changed to setStatusBarMessage.
Release Notes
Milestone:
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedReminder
After a PR is merged into the
master
branch, create a PR frommaster
to thenext
branch resolving any conflicts.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...