Change Theia GHA tests to use quay.io

[JillieBeanSim]

Signed-off-by: Billie Simmons 49491949+JillieBeanSim@users.noreply.github.com

Proposed changes

Release Notes

Milestone:

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

• I have read the CONTRIBUTOR GUIDANCE wiki
• PR title follows Conventional Commits Guidelines
• PR Description is included
• gif or screenshot is included if visual changes are made
• yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
• All checks have passed (DCO, Jenkins and Code Coverage)
• I have added unit test and it is passing
• I have added integration test and it is passing
• There is coverage for the code that I have added
• I have tested it manually and there are no regressions found
• I have added necessary documentation (if appropriate)
• Any PR dependencies have been merged and published (if appropriate)

Reminder

After a PR is merged into the master branch, create a PR from master to the next branch resolving any conflicts.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[JillieBeanSim]

I have it pulling the image from quay.io with tag 1.18.0. We do have some failing tests that could be due to the update to 1.18.0

@crawr could you help me with trying to fix the tests please

[JillieBeanSim]

I pulled the docker image of theia 1.18.0 from quay.io and installed the ZE plugin and it looks like the + button in the views isn't working. I click it and nothing happens

[JillieBeanSim]

I was able to fix the permission issues I was seeing by adding --user theia before mounting the .vsix when testing locally and the + will open the create profiles textboxes but I do see some issues with creating profiles in theia 1.18.0 using the text boxes. basePath won't let me enter passed without putting something in the textbox which causes the profile to fail. encoding acts the same way but won't cause issues having that in profiles. To fix the basePath I had to vi in and remove that line, refresh view then click search (magnifying glass).
I was playing some more and couldn't enter past username to try to leave those blank, not sure if this was an already known issue with theia though.

This is the command I was using locally to start up the docker image
docker run --init -it -p 3000:3000 --user theia -v "C:\Users\BillieSimmons\Documents\GitHub\PUBLIC\ZOWE\vscode-extension-for-zowe\dist\:/home/theia/plugins/" quay.io/zowe-explorer/theia:1.18.0

[crawr]

I get the same error when testing our v1.20.0 release in Theia 1.18.0. The text input will not allow blank input in the fields. The error message reverts to the URL prompt.

[JillieBeanSim]

@crawr I was curious about the can't find element error we get in the GHAs though so was going to look into that before giving this PR the go ahead and have a follow up with code changes that are theia specific for the create process. What do you think?

We may want to run more checks to see if anything else is broken in 1.18.0 too.

[crawr]

The "can't find error" is related to those empty input fields. It's expecting to find the next input prompt after "blank input" but it never comes up. Either we revise the tests to put "fake" in user/pw and values in other fields, or we investigate why it doesn't accept blank input anymore.

[JillieBeanSim]

The "can't find error" is related to those empty input fields. It's expecting to find the next input prompt after "blank input" but it never comes up. Either we revise the tests to put "fake" in user/pw and values in other fields, or we investigate why it doesn't accept blank input anymore.

@crawr I am thinking investigate since it will have to be fixed regardless right?

I don't think changing the test is good since it is suppose to help us find these breaking changes.

[JillieBeanSim]

@crawr @jellypuno I guess the follow up question is, do we want to go ahead and bring this change in knowing the theia tests are broken due to breaking changes in 1.18.0 or leave as is for the moment until we can investigate. As is, the tests are still broken due to the docker image not being available. We do already have the supported theia version documented so we are good on that.

[crawr]

My vote: I think we should review this as is, even if the tests are not passing, so we have a docker image going forward for testing.
It's just difficult for me to investigate the "blank input" issue, since I can't run debug session in Theia since the monorepo 😦

[lauren-li]

This PR looks good to me! The Theia GHA tests now appear to be pulling the latest image from quay.io. The failing Theia tests may be fixed by @phaumer's work on #1493 (comment), but those changes will not require updates in this PR.

Thanks @JillieBeanSim for this fix!

[crawr]

LGTM! Thanks @JillieBeanSim