Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Remove profile link command #1569

Merged
merged 4 commits into from
Nov 9, 2021
Merged

[next] Remove profile link command #1569

merged 4 commits into from
Nov 9, 2021

Conversation

crawr
Copy link
Contributor

@crawr crawr commented Nov 3, 2021

Signed-off-by: Richelle Anne Craw richelleanne.craw@broadcom.com

Proposed changes

Fixes #1280
This PR removes the Profile Link functionality from the commands.
The getProfile function was also moved from profilelink to utils/profileutils

Release Notes

Milestone: vNext

Changelog: Removed the profile link command

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Reminder

After a PR is merged into the master branch, create a PR from master to the next branch resolving any conflicts.

Further comments

A separate PR will be opened on the Zowe Docs site to remove the relevant Associate Profile section

Signed-off-by: Richelle Anne Craw <richelleanne.craw@broadcom.com>
@crawr crawr self-assigned this Nov 3, 2021
@crawr crawr added the vNext label Nov 3, 2021
Signed-off-by: Richelle Anne Craw <richelleanne.craw@broadcom.com>
Signed-off-by: Richelle Anne Craw <richelleanne.craw@broadcom.com>
@crawr crawr marked this pull request as ready for review November 4, 2021 11:44
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @crawr

@jellypuno jellypuno merged commit fc7c7cd into next Nov 9, 2021
@jellypuno jellypuno deleted the remove-profile-link branch November 9, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants