Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #845] Do not show undefined spool files for a job #1584

Merged
merged 2 commits into from
Nov 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"getChildren.search": "Use the search button to display jobs",
"ZoweJobNode.getJobs.spoolfiles": "Get Job Spool files command submitted.",
"getChildren.noSpoolFiles": "There are no JES spool messages to display",
"ZoweJobNode.getJobs.jobs": "Get Jobs command submitted.",
"getChildren.error.response": "Retrieving response from "
}
19 changes: 19 additions & 0 deletions packages/zowe-explorer/src/job/ZoweJobNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,25 @@ export class Job extends ZoweTreeNode implements IZoweJobTreeNode {
);
}
);
spools = spools
// filter out all the objects which do not seem to be correct Job File Document types
// see an issue #845 for the details
.filter(
(item) => !(item.id === undefined && item.ddname === undefined && item.stepname === undefined)
);
if (!spools.length) {
const noSpoolNode = new Spool(
localize("getChildren.noSpoolFiles", "There are no JES spool messages to display"),
vscode.TreeItemCollapsibleState.None,
this,
null,
null,
null,
this
);
noSpoolNode.iconPath = null;
return [noSpoolNode];
}
const refreshTimestamp = Date.now();
spools.forEach((spool) => {
let prefix = spool.stepname;
Expand Down