Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate jobs for extenders #1780

Merged
merged 5 commits into from May 10, 2022
Merged

Conversation

rudyflores
Copy link
Contributor

Signed-off-by: Rudy Flores 68666202+rudyflores@users.noreply.github.com

Proposed changes

Release Notes

Milestone:

Changelog: Fix duplicate jobs appearing in the jobs view upon making an owner/prefix filter search for extenders.

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Reminder

After a PR is merged into the master branch, create a PR from master to the next branch resolving any conflicts.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
@rudyflores rudyflores self-assigned this May 4, 2022
@rudyflores rudyflores mentioned this pull request May 4, 2022
16 tasks
@rudyflores
Copy link
Contributor Author

Comments for this PR were originally in #1683

phaumer
phaumer previously approved these changes May 4, 2022
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment about package failures

packages/zowe-explorer/src/job/ZoweJobNode.ts Outdated Show resolved Hide resolved
Signed-off-by: Rudy Flores <68666202+rudyflores@users.noreply.github.com>
@zFernand0 zFernand0 mentioned this pull request May 10, 2022
4 tasks
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @rudyflores for the fix =)

@JillieBeanSim JillieBeanSim merged commit fec7583 into master May 10, 2022
@JillieBeanSim JillieBeanSim deleted the remove-duplicate-jobs2 branch May 10, 2022 16:44
@zFernand0 zFernand0 mentioned this pull request Jul 5, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants