Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uss-tree): Fix getSessionNode from USS tree #1811

Merged
merged 3 commits into from May 18, 2022
Merged

Conversation

zFernand0
Copy link
Member

Proposed changes

Check to see if the parent is null. If so, return this.

Release Notes

Milestone: 2.0.2 (or higher)

Changelog: Fixed error "Cannot read getSessionNode of null"

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
@zFernand0
Copy link
Member Author

Please see build status in previous commit:
image

Copy link
Contributor

@rudyflores rudyflores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested this with two profiles based on z/OSMF, these two being one with credentials on it and one without credentials on it on USS and it seems to be able to perform a filter search successfully and work as intended!

Thanks for this change @zFernand0 !

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for your work on this @zFernand0

@JillieBeanSim JillieBeanSim merged commit 8ace8a0 into master May 18, 2022
@JillieBeanSim JillieBeanSim deleted the ze-1805 branch May 18, 2022 15:03
@zFernand0 zFernand0 mentioned this pull request Jul 5, 2022
55 tasks
@zFernand0 zFernand0 self-assigned this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USS search filter fails on credential-less profiles
3 participants