Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validate profile) Extra space in the dialog box text #1824

Merged
merged 3 commits into from Jun 2, 2022

Conversation

KutluOzel-b
Copy link
Contributor

Signed-off-by: KutluOzel-b kutlu.ozel@broadcom.com

Proposed changes

Fixed extra space in the Invalid Credentials dialog, at profile validation profilename

Release Notes

#1494

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • [ x] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

  • [ x] I have read the CONTRIBUTOR GUIDANCE wiki
  • [ x] PR title follows Conventional Commits Guidelines
  • [ x] PR Description is included
  • gif or screenshot is included if visual changes are made
  • [ x] yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • [x ] There is coverage for the code that I have added
  • [ x] I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>
@zFernand0 zFernand0 requested review from JillieBeanSim and removed request for jellypuno May 31, 2022 11:44
@zFernand0 zFernand0 linked an issue May 31, 2022 that may be closed by this pull request
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @KutluOzel-b

@zFernand0 zFernand0 merged commit b758d4a into master Jun 2, 2022
@zFernand0 zFernand0 deleted the bug/space_validate_profile branch June 2, 2022 13:16
@zFernand0 zFernand0 mentioned this pull request Jul 5, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra space in the dialog box text :)
3 participants