New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/refresh job/status #1936
Merged
Merged
Bug/refresh job/status #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>
Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>
Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>
Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>
JillieBeanSim
requested changes
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality LGTM, thanks @KutluOzel-b. Would you mind adding the bugfix description to the ZE CHANGELOG please.
Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>
…de-extension-for-zowe into bug/refresh_job/status
zFernand0
reviewed
Sep 15, 2022
Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
zFernand0
approved these changes
Sep 15, 2022
JillieBeanSim
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix refresh job & spool file pull from mainframe doesn't update job status by refreshing parent node.
Release Notes
Milestone:
#1857
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments
The Bug is solved by refreshing parent node method which leads to refreshing unnecessary nodes as well. Since we are populating nodes into belonging trees in a singular way this maybe not the best option but good for consistency.