Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/refresh job/status #1936

Merged
merged 11 commits into from Sep 15, 2022
Merged

Bug/refresh job/status #1936

merged 11 commits into from Sep 15, 2022

Conversation

KutluOzel-b
Copy link
Contributor

@KutluOzel-b KutluOzel-b commented Sep 9, 2022

Proposed changes

Fix refresh job & spool file pull from mainframe doesn't update job status by refreshing parent node.

Release Notes

Milestone:
#1857

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

The Bug is solved by refreshing parent node method which leads to refreshing unnecessary nodes as well. Since we are populating nodes into belonging trees in a singular way this maybe not the best option but good for consistency.

Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>
Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>
Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>
Signed-off-by: KutluOzel-b <kutlu.ozel@broadcom.com>
@zFernand0 zFernand0 linked an issue Sep 13, 2022 that may be closed by this pull request
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality LGTM, thanks @KutluOzel-b. Would you mind adding the bugfix description to the ZE CHANGELOG please.

Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JillieBeanSim JillieBeanSim merged commit 0b9bca5 into main Sep 15, 2022
@JillieBeanSim JillieBeanSim deleted the bug/refresh_job/status branch September 15, 2022 13:12
@JillieBeanSim JillieBeanSim added this to the 2.4.0 milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh Job doesn't update status
3 participants